Fix intermittent CI build failures and add basic Angular functional tests #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something about the lru types is very broken ATM (see the build result of #190, #191, etc.), from local error messages it seems that they are passthrough now and not required... but that conflicts with the linked logs. Very flaky, regardless, this all seems to resolve on an NPM install and on CI we are skipping that on an NPM cache hit. IMO we should just call
npm ci
everytime right now, until we can figure out why the NPM cache step is insufficient / flaking.While I was working on reproducing this I noted that the way we were packing adapter-angular/simple-server was also confusing things (see run #9114734835), so I took a pass on fixing that.
npm ci
run even on npm cache hit