feat: allow for AnalogJS builder to be used with Angular adapter #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
requested review from
Yuangwang,
sjjj986 and
jamesdaniels
as code owners
|
Honestly, we could probably drop enforcement of the application builder now that we have the environment variable. WDYT @sjjj986 @Yuangwang? |
|
Even better |
Sorry for the delay, just getting around to this now. What environment variable are you referring to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
@analogjs/platform:vitebuilder to be used in addition to the@angular-devkit/build-angular:applicationbuilder for Firebase App Hosting deployments.cc: @jamesdaniels