Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gif -> mp4 for the feature previews #81

Open
2 tasks
Feel-ix-343 opened this issue May 12, 2024 · 8 comments
Open
2 tasks

Gif -> mp4 for the feature previews #81

Feel-ix-343 opened this issue May 12, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@Feel-ix-343
Copy link
Owner

Feel-ix-343 commented May 12, 2024

https://www.reddit.com/r/logseq/comments/1cexbmq/comment/l1p0g1k/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

Faster load times

  • convert the gifs to mp4s
  • works?
@Feel-ix-343 Feel-ix-343 added the good first issue Good for newcomers label May 12, 2024
@ThatSealgair
Copy link

I am happy to implement this. Can I be assigned to this task?

@ThatSealgair
Copy link

So I looked into this. Unfortunately, what I gathered from this thread is that while technically possible, it may not be legal to implement. Another video format that could be used is .webm which would depend on client support to work.

@Feel-ix-343
Copy link
Owner Author

😨

I didn't know that.

Any format will work; it just needs to be preview-able on the README

Thank you so much for helping!

@ThatSealgair
Copy link

I misread the issue. I thought it was an add-on to this LSP. I'll check to see if a .webm works, if not, I'll try to fix the existing gifs to reduce file-size and loading times.

@Feel-ix-343
Copy link
Owner Author

Oh in that case, we could probably use mp4 on the readme, no?

This is better as viewers could pause the previews and they should affect the page load.

Would webm be better?

@ThatSealgair
Copy link

I should be able to get MP4 videos to work for this project's README. I'll try to get it done by tomorrow night.

@Feel-ix-343
Copy link
Owner Author

Amazing! Thank you

@Feel-ix-343
Copy link
Owner Author

Hey let me know if you need any help with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

2 participants