Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ๐Ÿž ๋ฒ„๊ทธ ๋ฆฌ์ŠคํŠธ ๐Ÿž #91

Open
5 of 9 tasks
nomatterjun opened this issue Mar 16, 2023 · 0 comments
Open
5 of 9 tasks
Assignees
Labels
๐Ÿž Bug ๋ฐœ๊ฒฌ๋œ ๋ฒ„๊ทธ (๋ชฉ๋ก, ํ•ด๊ฒฐ ์—ฌ๋ถ€)

Comments

@nomatterjun
Copy link
Member

nomatterjun commented Mar 16, 2023

๐Ÿ“‹ ์„ค๋ช…

  • ๋ฐœ์ƒํ•˜๊ณ  ์ธ์ง€ํ–ˆ์ง€๋งŒ ์šฐ์„ ์€ ๋„˜์–ด๊ฐ„ ๋ฒ„๊ทธ ๋ฆฌ์ŠคํŠธ

๐Ÿ ๋ฒ„๊ทธ๋ฆฌ์ŠคํŠธ

๊ตฌํ˜„ํ•ด์•ผํ•˜๋Š” ์ด์Šˆ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • bind ๋ฉ”์„œ๋“œ ๋‚ด๋ถ€์—์„œ CollectionView์™€ ๊ด€๋ จ๋œ ๊ธฐ๋Šฅ๋“ค์ด ๋™์ž‘ํ•˜์ง€ ์•Š๋Š” ํ˜„์ƒ

    • itemSelected, modelSelected ๋“ฑ
    • viewDidLoad์—์„œ ํ˜ธ์ถœํ•˜๋ฉด ์ •์ƒ ์ž‘๋™
    • Fixed RxDataSources ๋Œ€์‹  DffableDataSources๋ฅผ ์‚ฌ์šฉํ•œ ํ›„ ํ•ด๊ฒฐ๋จ
  • BottomSheet๊ฐ€ present๋˜์–ด ์žˆ๋Š” ๋™์•ˆ ํ›„๋ฐฉ์˜ selected๋œ ๋ฒ„ํŠผ์˜ ๋ฐฐ๊ฒฝ์ด ์ƒ๊ธฐ๋Š” ํ˜„์ƒ - Fixed 25db9b6

    ์ฐธ๊ณ  ์‚ฌ์ง„
  • configureCell๊ณผ configureSupplementaryView์—์„œ ๊ตฌ๋…ํ•œ ํ”„๋กœํผํ‹ฐ๊ฐ€ ๋ชจ๋“  cell๊ณผ supplementaryView์— ์ ์šฉ๋˜๋Š” ํ˜„์ƒ

  • ์•ฑ ๋Ÿฐ์น˜ ์‹œ ์„œ๋ฒ„ ์˜ค๋ฅ˜ or ๋„คํŠธ์›Œํฌ ์˜ค๋ฅ˜๋กœ ์ž๋™ ๋กœ๊ทธ์ธ์ด ์‹คํŒจํ•  ๊ฒฝ์šฐ ์Šคํ”Œ๋ž˜์‹œ ํ™”๋ฉด์—์„œ ๋ฉˆ์ถ”๋Š” ํ˜„์ƒ

  • ๋งˆ์ดํŽ˜์ด์ง€์˜ ์„ ๋ฌผ ๊ฐœ์ˆ˜๊ฐ€ ์ตœ์ดˆ viewDidLoad ์‹œ์ ์—์„œ ์—…๋ฐ์ดํŠธ๋˜์ง€ ์•Š๋Š” ํ˜„์ƒ

    • dequeue๋ฅผ ๋‹ค์‹œ ํ•  ๋•Œ ์—…๋ฐ์ดํŠธ ๋˜๊ณ  ์žˆ์Œ

โœจ ๊ฐœ์„ ์‚ฌํ•ญ

  • Realm๊ณผ ๊ด€๋ จ๋œ ๋™์ž‘๋“ค์„ Main ์“ฐ๋ ˆ๋“œ๊ฐ€ ์•„๋‹Œ Background ์“ฐ๋ ˆ๋“œ์—์„œ ๋™์ž‘ํ•˜๋„๋ก ๋ณ€๊ฒฝ
    • async / await?
    • DispatchQueue.realmThread ๋Œ€์‹  Concurrency์— ๋งž๋Š” utility๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ๋ณ€๊ฒฝ
      • Concurrency๋Š” ์“ฐ๋ ˆ๋“œ ๋ณด์žฅ์„ ํ•ด์ฃผ์ง€ ์•Š๊ธฐ ๋–„๋ฌธ์— ์‚ฌ์šฉํ•ด์•ผํ•จ
  • ๋„คํŠธ์›Œํฌ ์ง€์—ฐ ์‹œ UX ๊ฐœ์„  (timeout ๋“ฑ)
    • ํ˜„์žฌ์˜ ์ธํ„ฐ๋ž™์…˜์„ ๋ง‰๋Š” ๋กœ๋”ฉ ์ธ๋””์ผ€์ดํ„ฐ ๋Œ€์‹  ์ธํ„ฐ๋ž™์…˜์€ ๊ฐ€๋Šฅํ•œ ๋Œ€์‹  ๋‹ค๋ฅธ ๊ณณ์— ๋กœ๋”ฉ์ค‘์ด๋ผ๋Š” ๊ฒƒ์„ ํ‘œํ˜„ํ•˜๋Š” ์ธ๋””์ผ€์ดํ„ฐ ํ•„์š”
  • ๋ณ„๋„์˜ Flow๋ฅผ ๊ฐ€์ง€๋ฉฐ push๋œ ๋ทฐ๊ฐ€ pop๋  ๋•Œ .end๋ฅผ ํ†ตํ•ด ๋ฉ”๋ชจ๋ฆฌ์—์„œ ํ•ด์ œ๋˜์ง€ ๋ชปํ•˜๊ณ  ์žˆ๋Š” ๋ฌธ์ œ
    • ex: SearchVC๋Š” backButton์„ ํƒญํ•˜์—ฌ ๋’ค๋กœ ๊ฐˆ๋•Œ๋งŒ .end๊ฐ€ ํ˜ธ์ถœ๋˜๊ณ  ์žˆ์Œ
@nomatterjun nomatterjun added the ๐Ÿž Bug ๋ฐœ๊ฒฌ๋œ ๋ฒ„๊ทธ (๋ชฉ๋ก, ํ•ด๊ฒฐ ์—ฌ๋ถ€) label Mar 16, 2023
@nomatterjun nomatterjun pinned this issue Mar 16, 2023
@eung7 eung7 closed this as completed Jan 29, 2024
@eung7 eung7 reopened this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿž Bug ๋ฐœ๊ฒฌ๋œ ๋ฒ„๊ทธ (๋ชฉ๋ก, ํ•ด๊ฒฐ ์—ฌ๋ถ€)
Projects
None yet
Development

No branches or pull requests

2 participants