Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods created by DaemonSets are not validated #1038

Closed
ErikLundJensen opened this issue Mar 15, 2024 · 1 comment
Closed

Pods created by DaemonSets are not validated #1038

ErikLundJensen opened this issue Mar 15, 2024 · 1 comment
Labels
enhancement Adding additional functionality or improvements stale Marked as stale by stalebot triage This bug needs triage

Comments

@ErikLundJensen
Copy link

ErikLundJensen commented Mar 15, 2024

As described in #637 Polaris does not validate pods created by DaemonSets.

For example create a simple DaemonSet:

apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: my-daemonset
spec:
  selector:
    matchLabels:
      k8s-app: my-daemonset
  template:
    metadata:
      name: my-daemonset
      labels:
        k8s-app: my-daemonset
    spec:
      containers:
        - name: nginx
          image: nginx:1.25.3

The pod created by the DaemonSet does not show up at the Polaris dashboard. Isn't this a security risk if uses can create pods from DaemonSet without the webhook/dashboard validates the pod?

The documentation for Controller does not list DaemonSet : https://polaris.docs.fairwinds.com/customization/custom-checks/#available-options
which might indicate that it is not included.

Work-a-round, as I see it, is to copy Pod rules to PodSpec rules and keep them aligned.

@ErikLundJensen ErikLundJensen added enhancement Adding additional functionality or improvements triage This bug needs triage labels Mar 15, 2024
@ErikLundJensen
Copy link
Author

This is only true in for some DaemonSets. We are working at finding the exact reason why some DaemonSets are not processed.

@github-actions github-actions bot added the stale Marked as stale by stalebot label May 27, 2024
@github-actions github-actions bot closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements stale Marked as stale by stalebot triage This bug needs triage
Projects
None yet
Development

No branches or pull requests

1 participant