Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/goldilocks] feat: add allow setting priority class #1435

Conversation

barney71
Copy link
Contributor

@barney71 barney71 commented Mar 2, 2024

Why This PR?
With platform engineering it's important for infrastructure workloads to take precedence over user workloads when it comes to scheduling deployments. Defining priority classes comes to the rescue here.

Fixes #

Changes
Changes proposed in this pull request:

  • introducing 2 new values
  • introducing PriorityClass to controller and dashboard deployments

Checklist:

  • [ x] I have included the name of the chart in the title of this PR in square brackets i.e. [stable/goldilocks].
  • [x ] I have updated the chart version in Chart.yaml following Semantic Versioning.
  • [ x] Any new values are backwards compatible and/or have sensible default.
  • [x ] Any new values have been added to the README for the Chart, or helm-docs --sort-values-order=file has been run for the charts that support it.

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the stale Marked as stale by stalebot label May 3, 2024
@barney71
Copy link
Contributor Author

barney71 commented May 7, 2024

Hello Goldilocks team,
would someone please review this pr. Thanx.

@github-actions github-actions bot removed the stale Marked as stale by stalebot label May 8, 2024
@github-actions github-actions bot added the stale Marked as stale by stalebot label Jul 7, 2024
@github-actions github-actions bot closed this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Marked as stale by stalebot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants