[Design System] Alert, Confirm, Prompt #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 3, 2023
✅ Deploy Preview for ids-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| background: ${({ theme }) => theme.color.primary.blue500}; | ||
| border: none; | ||
| border-radius: 5px; | ||
| color: white; |
There was a problem hiding this comment.
컬러 코드는 디자인 시스템으로 통일하는게 좋을 것 같습니다.
| description: '', | ||
| confirmButtonLabel: '확인', | ||
| // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| onConfirm: () => {}, |
There was a problem hiding this comment.
어차피 옵셔널 인자라면 반드시 초기 상태로 넣어줄 필요는 없을 것 같습니다.
| alert.onConfirm(); | ||
| } | ||
|
|
||
| setAlert((prev) => ({ ...prev, open: false })); |
There was a problem hiding this comment.
이 경우에, 만약 이전 상태에서 description, confirmButtonLabel 등의 옵셔널 인자를 초기화 해주지 않으면, 해당 내용을 이후에 변경해주지 않고 사용할 때 이전 기록이 남아있을 것 같습니다.
| const openAlert = useContext(AlertContext); | ||
|
|
||
| return useCallback( | ||
| (title: string, description: string, onConfirm?: () => void, confirmButtonLabel?: string) => { |
There was a problem hiding this comment.
옵셔널 인자들은 순서에 영향을 받지 않도록 객체로 묶어서 사용하면 좋을 것 같습니다.
만약 onClose 등의 함수가 추가된다면 모든 코드에서 순서를 변경해야 하므로 어려움이 발생할 것 같네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요 🔍
작업 내용 📝
기타 사항 🙋♂️