Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Allow doing match/set tag untagged #15961

Merged
merged 2 commits into from May 13, 2024
Merged

lib: Allow doing match/set tag untagged #15961

merged 2 commits into from May 13, 2024

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented May 7, 2024 •
edited

Closes #15852

@frrbot frrbot bot added the libfrr label May 7, 2024
@ton31337 ton31337 mentioned this pull request May 7, 2024
Closed
2 tasks
@donaldsharp
Copy link
Member

there was some discussion on adding a match tag untagged instead of putting 0. It would be a better cli.

@ton31337
Copy link
Member Author

ton31337 commented May 8, 2024

What is the reason by using a word m, not a number?

@ton31337
Copy link
Member Author

ton31337 commented May 8, 2024

ci:rerun stucked

@donaldsharp
Copy link
Member

even though internally we consider 0 a untagged value. I would prefer to explicitly state it instead of having it as zero. Someone is going to ask for the ability to set 0 then. I would prefer untagged and hten value because of this.

@ton31337 ton31337 force-pushed the fix/allow_using_match_tag_0 branch from d06527a to 38c47cd Compare May 8, 2024 19:32
@github-actions github-actions bot added size/M and removed size/XS labels May 8, 2024
@ton31337 ton31337 changed the title lib: Allow doing match for tag 0 lib: Allow doing match/set tag untagged May 8, 2024
@ton31337
lib: Allow doing match/set tag untagged
e797b13 
In route-map: `match tag untagged`.

E.g. Cisco/Juniper allows that, but they use `match tag 0` instead.

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337
tests: Check if set/match tag untagged works
adce8e0 
Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 force-pushed the fix/allow_using_match_tag_0 branch from 38c47cd to adce8e0 Compare May 10, 2024 07:26
@frrbot frrbot bot added the tests Topotests, make check, etc label May 10, 2024
@github-actions github-actions bot added size/L and removed size/M labels May 10, 2024
@donaldsharp donaldsharp merged commit b6f1b32 into FRRouting:master May 13, 2024
11 checks passed
@ton31337 ton31337 deleted the fix/allow_using_match_tag_0 branch May 13, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
libfrr master size/L tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route-map Tag should possibly match also 0 (not tagged)
2 participants
@ton31337 @donaldsharp