-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For "buildWindows" locally, need filter to remove "-sdk" from "nw" retrieved from package.json #878
Comments
Do you install manually this two packages? in the github actions i install "manually" with the operating system in fact. Maybe we coud improe the build scripts to detect os and install this dependencies automatically, i'm sure this improve the developer experience. |
Yes I installed those when I found they were needed. If I'm thinking about this, it is not too important that a developer can use all the scripts, like "buildWindows" or the others that create an installer. Usually, it's just the pipeline that handles these build-release items. Why don't we just document these so that any developer knows it's possible? - even though they're probably not going to do it...
Like that? The hard work of builds & automation is already done. Tell me a place to document these and we can be finished with the issue. |
Hi @TimRudy! I would like icestudio to have its own development guide and minimal user guide, without wikis or external pages. For this, I put a new directory inside /docs called developers. If you agree with this, I think we could create Markdown files in it with the different aspects of the development to make the work easier in the future. I'm trying different Markdown parsers to generate after that "a page" that could be easily opened from Icestudio or in a browser (on github I could see the Markdown renderer, but it would be better if we could open it inside Icestudio). With the user manual I think we will do the same, I need to finish a couple of things that will change the user interface, and once finished I want to make some quick guides that are within Icestudio itself. Then we can put references to the wiki and other documentation sites. Thanks! |
For running
buildWindows
locally vianpm
, a filter is needed like this in.github\workflows\build-windows-manual.yml
:sed -i 's/\("nw": "[^"]*\)-sdk"/\1"/g' package.json
It should pass the correct NWJS to "nwjs:src" build - i.e. must use name "0.95.0" instead of "0.95.0-sdk". Don't use the
sed
command. It changespackage.json
in-place.Aside from this, "buildWindows" will work on Windows if:
gettext0.23-iconv1.17-static-64.exe
or latest versionNSIS.exe
"mkdir -p"
problem in Gruntfile is resolved (in another Issue)The text was updated successfully, but these errors were encountered: