Fix lints

Author: jennydaman

DEVELOP.md

@@ -0,0 +1,5 @@
+# Development Notes
+
+## Comments about `biome.json`
+
+- `lint/style/noNonNullAssertion` disabled because https://github.com/FNNDSC/fnndsc/issues/101

biome.json

@@ -14,7 +14,10 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true
+      "recommended": true,
+      "style": {
+        "noNonNullAssertion": "off"
+      }
     }
   },
   "vcs": {

src/components/VisualDatasets/client/DatasetFile.ts

@@ -13,7 +13,6 @@ import {
 import { Problem } from "../types.ts";
 import problems from "./problems.tsx";
 import { DatasetVolume, SupportedVolumeSettings } from "../models.ts";
-import { produce } from "immer";
 import { Option, none, some, match } from "fp-ts/Option";
 import { pipe } from "fp-ts/function";
 import { parse as parseJson } from "fp-ts/Json";
@@ -165,9 +164,8 @@ class DatasetFile {
   }
 
   get metadata(): DatasetFileMetadata {
-    return produce(this.options, (draft) => {
-      delete draft.niivue_defaults;
-    });
+    const { niivue_defaults: _, ...rest } = this.options;
+    return rest;
   }
 
   get tags(): TagSet {

src/components/VisualDatasets/client/DatasetFilesClient.ts

@@ -80,7 +80,7 @@ function isSubset(tags: TagSet, match: TagSet): boolean {
     if (!(key in tags)) {
       return false;
     }
-    if (tags[key] != value) {
+    if (tags[key] !== value) {
       return false;
     }
   }

src/components/VisualDatasets/client/helpers.ts

@@ -23,8 +23,7 @@ function findVisualDatasetInstancePairs(
       // contain all plugin instances of a feed, so we're going to badly
       // throw an Error here.
       throw new Error(
-        "Previous not found for pl-visual-dataset plugin instance " +
-          `id=${indexPlinst.data.id} previous_id=${prev}`,
+        `Previous not found for pl-visual-dataset plugin instance id=${indexPlinst.data.id} previous_id=${prev}`,
       );
     }
     return { indexPlinst, dataPlinst };

src/components/VisualDatasets/client/problems.tsx

@@ -143,7 +143,8 @@ const PROBLEMS = {
   },
 } satisfies Record<
   string,
-  Problem | ((...args: any[]) => Problem) | ((...args: any[]) => Problem[])
+  // biome-ignore lint/suspicious/noExplicitAny: it's fine to use any for rest arguments in satisfies operator
+  Problem | ((...args: any[]) => Problem | Problem[])
 >;
 
 export default PROBLEMS;

src/components/VisualDatasets/client/testData/feedplugininstancelist.ts

@@ -5,7 +5,7 @@ function getPluginInstances(): FeedPluginInstanceList {
   const list = new FeedPluginInstanceList("https://example.org", {
     token: "i am a mock, I have no token",
   });
-  list.collection = data["collection"];
+  list.collection = data.collection;
   return list;
 }
 

src/components/VisualDatasets/client/testData/plVisualDatasetFilebrowserFiles.ts

@@ -7,7 +7,7 @@ function getPlVisualDatasetFilebrowserFileList(): FileBrowserPathFileList {
   const list = new FileBrowserPathFileList("https://example.org", {
     token: "i am a mock, I have no token",
   });
-  list.collection = data["collection"];
+  list.collection = data.collection;
   return list;
 }