Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure write_*() toml functions have the correct output format #93

Open
soniamitchell opened this issue Jul 6, 2021 · 5 comments
Open
Labels

Comments

@soniamitchell
Copy link
Contributor

No description provided.

@soniamitchell soniamitchell changed the title Ensure write_*() functions have the correct output format Ensure write_*() toml functions have the correct output format Jul 7, 2021
@soniamitchell
Copy link
Contributor Author

@richardreeve if you get a chance, it would be great if you could look at this to see which bits are still accurate.

@soniamitchell soniamitchell added the question Further information is requested label Jul 13, 2021
@richardreeve
Copy link
Member

I think all of this (on the toml and hdf5 formats) is still accurate for now, but these formats may change over the next few months as we tie down exactly what data and metadata we most want to store in internal formats.

@soniamitchell
Copy link
Contributor Author

soniamitchell commented Jul 13, 2021

What I wanted more clarity on was things like this:

read_estimate(data_product, component) -> float or integer
If the component is represented as a point estimate, return that value.
If the component is represented as a distribution, return the distribution mean.
If the component is represented as samples, return the sample mean.

That is, using read_estimate() to read distributions or samples.. is that something we still want?
(I haven't implemented it yet)

@richardreeve
Copy link
Member

richardreeve commented Jul 13, 2021

That seemed the most logical thing to do at the time, and we haven't discussed it since then. However, I think the things on that page most likely to change are:

  1. The metadata associated with hdf5 components
  2. This kind of detail about how to handle toml components
  3. Whether to allow tables in toml files

I guess what I'm saying is that we may still want it, but we won't know for a month or two at least while we work through other issues.

@soniamitchell
Copy link
Contributor Author

Cool, I'll put this on hold then

@soniamitchell soniamitchell removed question Further information is requested validation labels Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants