Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will the submission script written by fair run always be a sh file? #170

Open
soniamitchell opened this issue Sep 27, 2021 · 7 comments
Open
Labels
question Further information is requested

Comments

@soniamitchell
Copy link
Contributor

Currently, I've been assuming it's a sh file. But presumably if it's copying a script from script_path, then it could be an R file, for example? In which case, is the script_path in the working config something that's staying?

@soniamitchell soniamitchell added the question Further information is requested label Sep 27, 2021
@richardreeve
Copy link
Member

No, it's not set to be a .sh file - you can set the shell, so it could just be an R script if you set the shell to R. At the moment you should only need to "guess" the location of the working config file, because that will contain the path to the script in run_metadata. However, it's an argument to initialise()! Not ideal...

The idea is before Christmas(?) we rewrite this so we register the files in the registry and pass the uuids of the object (or the file hashes) to the DPAPI rather than the folder, but then we need to know how to return the coderuns that were created... for the time being any hack that works is fine.

@richardreeve
Copy link
Member

In particular script_path would become script_uuid probably?

@soniamitchell
Copy link
Contributor Author

The code runs are still output to coderuns.txt?

Is the script still called script at least, whatever the extension might be?

@richardreeve
Copy link
Member

For the time being everything stays the same. After we've submitted, we can start playing around with it again. For now, definitely script.ext and coderuns.txt so everyone is developing against a fixed target.

@richardreeve
Copy link
Member

richardreeve commented Sep 27, 2021

In fact for now script.sh and coderuns.extcoderuns.txt...

@soniamitchell
Copy link
Contributor Author

Is this a typo? or is there some benefit to coderuns having different extensions?

@richardreeve
Copy link
Member

It's a typo, sorry - coderuns.txt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants