Customize line height for headings #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: check |
|
I found some inconsistencies between iOS and Android platforms: h1 text on Android is centered, on the other hand on iOS it is justified to the bottom of the line |
|
These are test screenshots to make sure this PR doesn't break anything on main(left - state of main, right - state of PR):
|
|
Related change in react-native: facebook/react-native#47271 |
|
TODO: heading line height when nested in blockquote on iOS 
|
|
TODO: center text vertically on iOS 
|
|
Android is okay 
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds
h1.lineHeighttomarkdownStyle. If not set,MarkdownTextInputwill use OS-default line height (appropriate toh1.fontSize). If set, this will override OS-default line height.Looks like Codegen still doesn't have proper support for
Float | undefined(and neither forFloat | null) so I had to go with-1as the default value.Closes #522.
Related Issues
#522
Manual Tests
Linked PRs