From 986ce3deb1c4cfe07af22395c4e8a970126eea06 Mon Sep 17 00:00:00 2001 From: Cristi Paval Date: Thu, 30 Jan 2025 18:20:15 +0200 Subject: [PATCH 1/2] Fix useTripTransactions hook --- src/hooks/useTripTransactions.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/hooks/useTripTransactions.ts b/src/hooks/useTripTransactions.ts index d375b77da564..f8fba3bcc565 100644 --- a/src/hooks/useTripTransactions.ts +++ b/src/hooks/useTripTransactions.ts @@ -27,8 +27,7 @@ function useTripTransactions(reportID: string | undefined): Transaction[] { return Object.values(transactions ?? {}).filter((transaction): transaction is Transaction => !!transaction && tripTransactionReportIDs.includes(transaction.reportID)); }, - }); - + }, [tripTransactionReportIDs]); return tripTransactions; } From 81680dcd15c3cd17856503d2a02ada90cdf099d5 Mon Sep 17 00:00:00 2001 From: Cristi Paval Date: Thu, 30 Jan 2025 18:27:55 +0200 Subject: [PATCH 2/2] Lint and prettier fixes --- src/hooks/useTripTransactions.ts | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/hooks/useTripTransactions.ts b/src/hooks/useTripTransactions.ts index f8fba3bcc565..2260097a4112 100644 --- a/src/hooks/useTripTransactions.ts +++ b/src/hooks/useTripTransactions.ts @@ -19,15 +19,19 @@ function useTripTransactions(reportID: string | undefined): Transaction[] { .filter((report) => report && report.chatReportID === reportID) .map((report) => report?.reportID), }); - const [tripTransactions = []] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, { - selector: (transactions) => { - if (!tripTransactionReportIDs.length) { - return []; - } + const [tripTransactions = []] = useOnyx( + ONYXKEYS.COLLECTION.TRANSACTION, + { + selector: (transactions) => { + if (!tripTransactionReportIDs.length) { + return []; + } - return Object.values(transactions ?? {}).filter((transaction): transaction is Transaction => !!transaction && tripTransactionReportIDs.includes(transaction.reportID)); + return Object.values(transactions ?? {}).filter((transaction): transaction is Transaction => !!transaction && tripTransactionReportIDs.includes(transaction.reportID)); + }, }, - }, [tripTransactionReportIDs]); + [tripTransactionReportIDs], + ); return tripTransactions; }