Expense - Old merchant shown on the expense row in the report when edited in Reports

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176922/test-cases/41237504
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 15 iOS 26.1
App Component: Money Requests

Action Performed:

1. Sign in to ND
2. Create two expenses in one report in the workspace chat
3. Navigate to the Reports tab/ Expenses
4. Select one of the just created expenses and change the merchant
5. Navigate to the workspace chat, open the report
6. Observe the merchant on the expense, where the merchant was edited

Expected Result:

Merchant is updated on the expense row in the expenses list in the report

Actual Result:

Merchant is not updated on the expense row in the expenses list in the report, when the merchant was edited in the Reports tab

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant is not updated on the expense row in the expenses list in the report, when the merchant was edited in the Reports tab

What is the root cause of that problem?

We use transaction.formattedMerchant for primary merchant calculation in TransactionItemRow:

App/src/components/TransactionItemRow/index.tsx

Line 119 in f82a8db

let merchant = transactionItem?.formattedMerchant ?? getMerchant(transactionItem);

When updating merchant this value is not updated, so the old value is still displayed.

TransactionItemRow is used in both Report page and Search page, but we don't see the same issue in Reports > Expenses page, this is because transaction.formattedMerchant was recalculated in Search page:

App/src/components/Search/index.tsx

Lines 417 to 429 in f82a8db

	const [filteredData1, allLength] = getSections({
	type,
	data: searchResults.data,
	currentAccountID: accountID,
	currentUserEmail: email ?? '',
	formatPhoneNumber,
	groupBy: validGroupBy,
	reportActions: exportReportActions,
	currentSearch: searchKey,
	archivedReportsIDList: archivedReportsIdSet,
	queryJSON,
	isActionLoadingSet,
	});

App/src/libs/SearchUIUtils.ts

Line 1817 in f82a8db

return getTransactionsSections(data, currentSearch, currentAccountID, currentUserEmail, formatPhoneNumber, isActionLoadingSet);

App/src/libs/SearchUIUtils.ts

Lines 1099 to 1106 in f82a8db

	const {formattedFrom, formattedTo, formattedTotal, formattedMerchant, date} = getTransactionItemCommonFormattedProperties(
	transactionItem,
	from,
	to,
	policy,
	formatPhoneNumber,
	report,
	);

What changes do you think we should make in order to solve the problem?

We can use the same logics in SearchUIUtils to recalculate merchant in MoneyRequestReportTransactionList

App/src/libs/SearchUIUtils.ts

Lines 661 to 662 in f82a8db

	const merchant = getTransactionMerchant(transactionItem, policy);
	const formattedMerchant = merchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT ? '' : merchant;

formattedMerchant: getMerchant(transaction, policy) === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT ? '' : getMerchant(transaction, policy),

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 261 to 264 in f82a8db

	.map((transaction) => ({
	...transaction,
	shouldBeHighlighted: newTransactions?.includes(transaction),
	}));

What alternative solutions did you explore? (Optional)

Looking at formattedMerchant description:

App/src/components/TransactionItemRow/index.tsx

Lines 69 to 70 in f82a8db

	/** formatted "merchant" value used for displaying and sorting on Reports page */
	formattedMerchant?: string;

We see that this value is only used in Report > Expenses page, so we can limit its usage here:

let merchant = (isSearchTopmostFullScreenRoute() ? transactionItem?.formattedMerchant : undefined) ?? getMerchant(transactionItem);

App/src/components/TransactionItemRow/index.tsx

Line 119 in f82a8db

let merchant = transactionItem?.formattedMerchant ?? getMerchant(transactionItem);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.