Infinite loading on announce room when changing role to a member

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): gibethlehem@gmail.com
Issue reported by: Applause Internal Team
Device used: macOS/chrome
App Component: Workspace Settings

Action Performed:

1. Create a Workspace with 2 members, User A and User B
2. Make User A an Admin
3. Login to User A > Go to Announce room
4. Click on the Header > Members > Click on a member to go to the profile page
5. Now as the owner make User A just a member, remove from admin.

Expected Result:

User A is redirected to concierge page

Actual Result:

Infinite loading on Announce room

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Infinite loading on Announce room

What is the root cause of that problem?

When we change user A from admin to member, user A still has access to the announcement room => isEmpty(report) will be false => isRemovalExpectedForReportType will be false

App/src/pages/home/ReportScreen.tsx

Lines 693 to 700 in f82a8db

	const isRemovalExpectedForReportType =
	isEmpty(report) &&
	(isMoneyRequest(prevReport) ||
	isMoneyRequestReport(prevReport) ||
	isPolicyExpenseChat(prevReport) ||
	isGroupChat(prevReport) ||
	isAdminRoom(prevReport) ||
	isAnnounceRoom(prevReport));

=> The logic to dismiss the modal and navigate to the concierge will not be triggered.

App/src/pages/home/ReportScreen.tsx

Lines 726 to 740 in f82a8db

	Navigation.dismissModal();
	if (Navigation.getTopmostReportId() === prevOnyxReportID) {
	Navigation.isNavigationReady().then(() => {
	Navigation.popToSidebar();
	});
	}
	if (prevReport?.parentReportID) {
	// Prevent navigation to the IOU/Expense Report if it is pending deletion.
	if (isMoneyRequestReportPendingDeletion(prevReport.parentReportID)) {
	return;
	}
	Navigation.isNavigationReady().then(() => {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));
	});
	return;

What changes do you think we should make in order to solve the problem?

We should update the condition of isRemovalExpectedForReportType. For the announcement room, the member must be admin

        const isRemovalExpectedForReportType =
            (isEmpty(report) &&
                (isMoneyRequest(prevReport) ||
                    isMoneyRequestReport(prevReport) ||
                    isPolicyExpenseChat(prevReport) ||
                    isGroupChat(prevReport) ||
                    isAdminRoom(prevReport) ||
                    isAnnounceRoom(prevReport))) ||
            (isAnnounceRoom(report) && !isPolicyAdmin(policy));

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After demoting a workspace admin who is viewing an Announce room, the room stops being accessible. Instead of sending the user back to Concierge, it shows the Announce room and shows an endless loading state.

What is the root cause of that problem?

The ReportScreen removal check only treats an empty report object as a signal to navigate away. When an Announce or Admin room becomes inaccessible, Onyx marks the report with errorFields.notFound instead of clearing the object, so the existing condition never triggers. The navigation logic therefore kept the user on an inaccessible report, producing the infinite loading.

App/src/pages/home/ReportScreen.tsx

Lines 690 to 703 in 5d3d7ef

	const onyxReportID = report?.reportID;
	const prevOnyxReportID = prevReport?.reportID;
	const wasReportRemoved = !!prevOnyxReportID && prevOnyxReportID === reportIDFromRoute && !onyxReportID;
	const isRemovalExpectedForReportType =
	isEmpty(report) &&
	(isMoneyRequest(prevReport) ||
	isMoneyRequestReport(prevReport) ||
	isPolicyExpenseChat(prevReport) ||
	isGroupChat(prevReport) ||
	isAdminRoom(prevReport) ||
	isAnnounceRoom(prevReport));
	const didReportClose = wasReportRemoved && prevReport.statusNum === CONST.REPORT.STATUS_NUM.OPEN && report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED;
	const isTopLevelPolicyRoomWithNoStatus = !report?.statusNum && !prevReport?.parentReportID && prevReport?.chatType === CONST.REPORT.CHAT_TYPE.POLICY_ROOM;
	const isClosedTopLevelPolicyRoom = wasReportRemoved && prevReport.statusNum === CONST.REPORT.STATUS_NUM.OPEN && isTopLevelPolicyRoomWithNoStatus;

What changes do you think we should make in order to solve the problem?

Treat a report that now has errorFields.notFound the same as a removed report so the redirect path runs consistently.

Updated logic in ReportScreen:

const didLoseReportAccess = !!prevOnyxReportID && prevOnyxReportID === reportIDFromRoute && report?.errorFields?.notFound;
const isRemovalExpectedForReportType =
    (isEmpty(report) || didLoseReportAccess) &&
    (isMoneyRequest(prevReport) ||
        isMoneyRequestReport(prevReport) ||
        isPolicyExpenseChat(prevReport) ||
        isGroupChat(prevReport) ||
        isAdminRoom(prevReport) ||
        isAnnounceRoom(prevReport));
const didReportClose = wasReportRemoved && prevReport?.statusNum === CONST.REPORT.STATUS_NUM.OPEN && report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED;
const isClosedTopLevelPolicyRoom = wasReportRemoved && prevReport?.statusNum === CONST.REPORT.STATUS_NUM.OPEN && isTopLevelPolicyRoomWithNoStatus;