[$250] Wallet - Default badge not reassigned when deleting the top default payment account

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.38-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176692/test-cases/41236751
Email or phone of affected tester (no customers): testing210790+new3@gmail.com
Issue reported by: Applause Internal Team
Device used: Windwos 11/ Chrome
App Component: Other

Action Performed:

1.Navigate to the Wallet page of an account with at least two deposit accounts.
2.Ensure the top account is set as the default payment method (has the default badge).
3.Click the three-dot menu on the default account.
4.Select Delete.
5.Confirm the deletion.
6.Observe the remaining account list.

Expected Result:

After deleting the default account, the most recent prior added account should automatically become the new default payment method and display the default badge.

Actual Result:

When the deleted default account is positioned at the top of the list, no account is automatically set as default — the default badge disappears completely, even though there’s still another valid account remaining.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6984119_1761395563202.Grabando__551.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021986433186932629797
• Upwork Job ID: 1986433186932629797
• Last Price Increase: 2025-11-20

Issue Owner

Current Issue Owner: @AndrewGable

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Ammar110]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user deletes their default payment account from the Wallet page, the “Default” badge disappears even though other valid accounts remain. The app fails to automatically assign a new default, causing confusion and inconsistent Wallet state.

What is the root cause of that problem?

The deletion flow doesn’t trigger reassignment of the default account.
In src/libs/actions/PaymentMethods.js (or its linked Onyx data file), the account is removed but the defaultPaymentMethodID or walletLinkedAccountID isn’t updated.

Consequently, front-end components in src/pages/settings/Wallet/ (notably WalletPage.js and PaymentMethodList.js) receive stale data and render no item as default.

What changes do you think we should make in order to solve the problem?

• In PaymentMethods.js, after deletion, check if the removed account was default.
• If yes, fetch remaining accounts and assign the first valid one as the new default.
• Update the Onyx key (ONYXKEYS.USER_WALLET → walletLinkedAccountID) with the new default ID.
• Ensure UI components (WalletPage.js, PaymentMethodList.js) re-render after the Onyx update so the badge appears correctly.
• Add unit and E2E tests to confirm new default reassignment works automatically.

What alternative solutions did you explore? (Optional)

• Manual reassignment by user — rejected for added friction.
• Modal prompt for new default — rejected for slowing UX.

[melvin-bot]

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dylanexpensify]

@joekaufmanexpensify this sounds like a bug, would you agree?

[joekaufmanexpensify]

Agreed.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021986433186932629797