[Due for payment 2025-12-04] [$250] Enable no-array-for-each lint rule

[roryabraham]

Coming from #67420

---

Problem

When .forEach() is used, then we incur unnecessary performance overhead because function calls are used for each loop iteration, and it is impossible to stop iteration early.

Solution

Enable eslint-plugin-unicorn’s no-array-for-each rule to enforce that plain for or for-of loops are used instead of .forEach loops.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021968163385112918222
• Upwork Job ID: 1968163385112918222
• Last Price Increase: 2025-10-17

Issue Owner

Current Issue Owner: @greg-schroeder

[roryabraham]

https://expensify.slack.com/archives/C05LX9D6E07/p1755719761872409?thread_ts=1755719385.116499&cid=C05LX9D6E07

[roryabraham]

Looking for a team of two volunteers to take this on: https://expensify.slack.com/archives/C08CZDJFJ77/p1756853317764529