Add PlusMinus icon and allow negative values in MoneyRequestAmountInput

[pasyukevich]

Explanation of Change

Fixed Issues

$ #53441
PROPOSAL:

Tests

For mobile:
1. Open the “Create Expense” screen.
2. Enter an amount and press “Flip”.
3. Verify that a minus sign appears before the currency.
4. Submit the expense.
5. Open the newly created expense.
6. Verify that the amount does not have a minus sign.
7. Tap on the amount and confirm that the minus sign appears before the currency.

For desktop:
1. Open the “Create Expense” screen.
2. Enter an amount and place the cursor at the beginning.
3. Press minus
4. Verify that a minus sign appears before the currency.
5. Press minus one more time
6. Verify that a minus sign disappeared before the currency.
7. Add minus again and clear the amount with "backspace"
8. After input is clear, press backspace one more time and verify that minus was removed
9. Add minus again and enter the amount
10. Submit the expense.
11. Open the newly created expense.
12. Verify that the amount does not have a minus sign.
13. Tap on the amount and confirm that the minus sign appears before the currency.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

For mobile:
1. Open the “Create Expense” screen.
2. Enter an amount and press “Flip”.
3. Verify that a minus sign appears before the currency.
4. Submit the expense.
5. Open the newly created expense.
6. Verify that the amount does not have a minus sign.
7. Tap on the amount and confirm that the minus sign appears before the currency.

For desktop:
1. Open the “Create Expense” screen.
2. Enter an amount and place the cursor at the beginning.
3. Press minus
4. Verify that a minus sign appears before the currency.
5. Press minus one more time
6. Verify that a minus sign disappeared before the currency.
7. Add minus again and clear the amount with "backspace"
8. After input is clear, press backspace one more time and verify that minus was removed
9. Add minus again and enter the amount
10. Submit the expense.
11. Open the newly created expense.
12. Verify that the amount does not have a minus sign.
13. Tap on the amount and confirm that the minus sign appears before the currency.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-native-converted.webm

Android: mWeb Chrome

android-web-converted.webm

iOS: Native

ios-native-converted.mp4

iOS: mWeb Safari

ios-web-converted.mp4

MacOS: Chrome / Safari

desktop-web-converted.mov

MacOS: Desktop

desktop-native-converted.mov

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[melvin-bot]

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ZhenjaHorbach]

And I think we need to update the optimistic data Since after changing an amount For a split second we have the old value displayed in the amount and in a report message

2025-03-05.10.19.51.mov

We still have this issue

[ZhenjaHorbach]

I feel like you should only be able to press - at the beginning of the input, otherwise it wouldn't make sense to allow the user to input a number like 6-6

@shawnborton
And could you clarify this please ?
Is it okay that on desktops we can flip the sign only at the beginning of the input ?

2025-03-05.17.03.44.mov

I think it would be more convenient to flip the sign at any time
And when we click on the minus sign, we would simply switch from a negative amount to a positive amount

[ZhenjaHorbach]

We have 400 error when split expense with negative amount

2025-03-05.17.20.57.mov

[pasyukevich]

We still have this issue

Could you check if you are using the latest version?
Not reproducible for me

Screen.Recording.2025-03-05.at.21.20.45.mov

[pasyukevich]

We have 400 error when split expense with negative amount

@ZhenjaHorbach
Added here - #53441 (comment)

[ZhenjaHorbach]

We still have this issue

Could you check if you are using the latest version? Not reproducible for me

Strange 🧐
In your case, only the amount changes with a delay
But I will retest tomorrow morning !

[ZhenjaHorbach]

Still easy to reproduce

Dev

2025-03-06.11.11.25.mov

Staging

2025-03-06.11.12.09.mov

[ZhenjaHorbach]

@pasyukevich
Actually on your video we have another bug

That the minus sign is reset to amount

2025-03-06.11.24.34.mov

[pasyukevich]

@ZhenjaHorbach The Issue with minus disappearing is on the API part since it is the UpdateMoneyRequestAmountAndCurrency method that returns positive amount

Commented earlier - #53441 (comment)

[pasyukevich]

According to this comment - #53441 (comment)

I will update the PR to limit negative functionality

[pasyukevich]

Updates:

• I found the root cause of the bug, which was negative and positive expenses in the workspace. It is partially on the FE (just fixed) and partially on the API sides
• Rechecked all cases for workspace only with API and posted issues here - [$250] Cannot make an expense negative #53441 (comment)

I will continue work with a focus only on limitations for this functionality

[shawnborton]

What's the latest on this one?

[pasyukevich]

I've posted the issues that I've found here: #53441 (comment)

waiting for clarification or fixes since it is the core of the feature to finalize

[JmillsExpensify]

Clarified in the issue regarding expected behavior.

[pasyukevich]

Thanks!

I will continue work here

[pasyukevich]

Updates:

• Will focus on it this week as main priority

[pasyukevich]

Updates:

Coming back to this issue

[shawnborton]

What's the latest here?

[pasyukevich]

Updates:

• Rebased PR
• Working on discussed limitations

[pasyukevich]

Updates:

• Working on the discussed limitations

Next steps - take into account that the API returns the opposite value of the amount

[pasyukevich]

Updates:

• Limitations for negative functionality implemented
• Working on opposite value handling