Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-13] Approver is showing as travel booking member #55906

Closed
1 of 8 tasks
m-natarajan opened this issue Jan 29, 2025 · 16 comments
Closed
1 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented Jan 29, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name): travel

Action Performed:

  1. Book a trip as a member of the room
  2. Open the expense details

Expected Result:

Should show member avatar in the expense details

Actual Result:

Showing approver avatar as if they booked travel

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence Please refer to OP for the screenshots

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @zanyrenney
@m-natarajan m-natarajan added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed labels Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, recently I've been working on all travel related issues with @shubham1206agra as a C+ as we both have access to travel workspaces.

@blazejkustra
Copy link
Contributor

Update: I have a fix but I want to better understand why was this implemented like this in the first place. This PR implemented the current logic and they had a similar problem

@blazejkustra
Copy link
Contributor

PR is ready for review @shubham1206agra!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 6, 2025
@melvin-bot melvin-bot bot changed the title Approver is showing as travel booking member [Due for payment 2025-02-13] Approver is showing as travel booking member Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 6, 2025

@shubham1206agra @zanyrenney @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link

melvin-bot bot commented Feb 12, 2025

@rlinoz @blazejkustra @zanyrenney @shubham1206agra this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Payment Summary

Upwork Job

BugZero Checklist (@zanyrenney)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

Sorry, something went wrong.

@melvin-bot melvin-bot bot added the Overdue label Feb 17, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

@rlinoz, @blazejkustra, @zanyrenney, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

@zanyrenney
Copy link
Contributor

@shubham1206agra i have sent you an offer to the job: https://www.upwork.com/jobs/~021891904876569493968

@melvin-bot melvin-bot bot removed the Overdue label Feb 18, 2025
@zanyrenney
Copy link
Contributor

@blazejkustra is from an expert agency so does not require payment.

@melvin-bot melvin-bot bot added the Overdue label Feb 21, 2025
@zanyrenney
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2025
@zanyrenney
Copy link
Contributor

spoke to @shubham1206agra in DM- paid through ND now.

@zanyrenney
Copy link
Contributor

Payment Summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Development

No branches or pull requests

6 participants