-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Due for payment 2025-02-13] Approver is showing as travel booking member #55906
Comments
Triggered auto assignment to @zanyrenney ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Hey! I’m Błażej Kustra from Software Mansion, an expert agency, recently I've been working on all travel related issues with @shubham1206agra as a C+ as we both have access to travel workspaces. |
Update: I have a fix but I want to better understand why was this implemented like this in the first place. This PR implemented the current logic and they had a similar problem |
PR is ready for review @shubham1206agra! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-13. 🎊 For reference, here are some details about the assignees on this issue:
|
@shubham1206agra @zanyrenney @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
@rlinoz @blazejkustra @zanyrenney @shubham1206agra this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Payment Summary
BugZero Checklist (@zanyrenney)
|
@rlinoz, @blazejkustra, @zanyrenney, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too... |
@shubham1206agra i have sent you an offer to the job: https://www.upwork.com/jobs/~021891904876569493968 |
@blazejkustra is from an expert agency so does not require payment. |
spoke to @shubham1206agra in DM- paid through ND now. |
Payment Summary
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name): travel
Action Performed:
Expected Result:
Should show member avatar in the expense details
Actual Result:
Showing approver avatar as if they booked travel
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Please refer to OP for the screenshotsView all open jobs on GitHub
Issue Owner
Current Issue Owner: @zanyrenneyThe text was updated successfully, but these errors were encountered: