[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [mWeb iOS / Safari 17.2] - PDF attachment doesn't load (endless spinner)

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jjcoffee
Slack conversation (hyperlinked to channel name): Expensify-bugs

Action Performed:

1. Add any PDF attachment to a chat.
2. Open the attachment.

Expected Result:

Attachment displays.

Actual Result:

Attachment doesn't load, the spinner spins endlessly.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

ios-safari-2025-01-13_15.37.01.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[jjcoffee]

I can reproduce (I am the bug reporter), please assign me @VictoriaExpensify.

ios-safari-2025-01-13_15.37.01.mp4

[rezkiy37]

Working on the issue.

[rezkiy37]

I just found one more bug related to Expensify/react-fast-pdf#30. The problem is replicable on the latest package version. However, I can see that the package version in the example is pretty old - 1.0.2 while the current is 1.0.21. I am going to upgrade the package version and fix the bug. Basically, it conflicts with styles.

Bug.mp4

[rezkiy37]

After investigations, I've found only one combination that works with IOS 17.x. It is the legacy PDF worker. Moreover, it must be unminimized - pdfjs-dist/legacy/build/pdf.worker.mjs.

pdfjs-dist/legacy/build/pdf.worker.mjs.

pdfjs-dist/legacy/build/pdf.worker.min.mjs.

[rezkiy37]

No overdue. I am actively working on the issue.

[jjcoffee]

I think @VictoriaExpensify might need to comment in order to remove the overdue label. Please assign me while you're at it 😄

[rezkiy37]

I just opened Expensify/react-fast-pdf#43 for review.

[rezkiy37]

To do:

1. Investigate if possible to apply the latest PDF.js worker for newer features and optimization.
2. Fix the example [HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [mWeb iOS / Safari 17.2] - PDF attachment doesn't load (endless spinner) #55176 (comment).
3. Upgrade react-fast-pdf version in the example.
4. Upgrade react-fast-pdf version in the Expensify app.

[rezkiy37]

I just opened Expensify/react-fast-pdf#42 for review.

[rezkiy37]

The PRs in review.

[rezkiy37]

Can we add a reviewing label?

[rezkiy37]

I just opened #55421 for review.

[rezkiy37]

I just found the official doc and a link to test by Mozilla. It can confirm that IOS Safari 17.x supports only the legacy worker.

Details

https://github.com/mozilla/pdf.js?tab=readme-ov-file#online-demo

[rezkiy37]

I am working on some dynamic solutions to apply the correct worker for the latest browsers and the legacy for the older ones.

[rezkiy37]

I have an idea:

1. Import both workers.
2. Get IOS version.
3. If <18 - legacy; if >=18 - modern.

Testing it.

[rezkiy37]

Working on the idea above. The project is not stable yet with this change.

[rezkiy37]

Other tasks have occupied me today.

[rezkiy37]

@tgolen has found one regression. I am working on the fix.

#55421 (comment), #55421 (comment)

[rezkiy37]

Just opened for review #55743.

[rezkiy37]

Other tasks have occupied me today. I am working on the issue tomorrow.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump react-fast-pdf #55421

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment through NewDot Manual Requests
• @rezkiy37 does not require payment (Contractor)
• @jjcoffee requires payment through NewDot Manual Requests

[melvin-bot]

@jjcoffee @VictoriaExpensify @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[rezkiy37]

I still have some tasks to work on. The issue in not completed yet.

[rezkiy37]

Just opened for review Expensify/react-fast-pdf#44.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Webpack configuration to use the minified pdf.worker file #55743

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment through NewDot Manual Requests
• @rezkiy37 does not require payment (Contractor)
• @jjcoffee requires payment through NewDot Manual Requests

[melvin-bot]

@jjcoffee @VictoriaExpensify @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[rezkiy37]

I still have some tasks to work on. The issue in not completed yet.

[rezkiy37]

Other tasks have occupied me today. I am working on the issue tomorrow.

[rezkiy37]

Testing it today.