[$250][Private Domain Onboarding Check] Implement frontend

[blimpich]

Implement frontend from the detailed design portion of the design doc: https://docs.google.com/document/d/1JlM9G3jZpaHDlcILWL9170ancMLtOnI2a73dQgX6ENo/edit?tab=t.0#heading=h.cyjz316lbaic

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021867347227654291292
• Upwork Job ID: 1867347227654291292
• Last Price Increase: 2024-12-12
• Automatic offers:
• ikevin127 | Reviewer | 105314976
• allgandalf | Contributor | 105314977

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021867347227654291292

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

Upwork job price has been updated to $250

[blimpich]

Accidentally got rid of the price in the title, didn't mean to do that. Assigning @allgandalf as they are the C+ who we hired to implement this portion of the design doc. They wrote the detailed design.

@ikevin127 I'll add you to the design doc so you can see what the overall idea is / get more context if needed.

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[blimpich]

Assigning myself as the CME and assigning Mitch as the bug-zero member since Mitch has context about the project and also the contract with Gandalf to do this work. Sorry for the unnecessary ping @michaelkwardrop!

[allgandalf]

🔴 Update: Working through the PR, @ikevin127 let me know if you have any doubts from the design doc 😄

[allgandalf]

Nothing much, I have the UI ready waiting for api commands to be ready to test it, i was getting some weird error the last time i tried addWorkEmail, but will test again today

[blimpich]

Sounds good, if the backend endpoints behave in any way that doesn't seem right please feel free to message me. I wrote a lot of tests for the backend but there will probably be a few bugs to work out that I inevitably missed 👍

[melvin-bot]

@blimpich, @MitchExpensify, @ikevin127, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

[allgandalf]

not overdue melvvvv, we hit a firewall issue, that should be resolved soon...

[allgandalf]

we're working on this , most of the convo is happening 1:1 with @blimpich :))

[melvin-bot]

@blimpich, @MitchExpensify, @ikevin127, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

[blimpich]

Not overdue, we're working on this. Shush Melvin

[blimpich]

Waiting on this PR to deploy

[allgandalf]

not overdue melv!!!

[blimpich]

All good @allgandalf? Need anything from me?

[melvin-bot]

@blimpich, @MitchExpensify, @ikevin127, @allgandalf Huh... This is 4 days overdue. Who can take care of this?

[blimpich]

@allgandalf when you get a chance can you provide an eta for when you think the PR will be up in review?

[blimpich]

Update

Frontend PR is here, we expect it to be in review by the end of the week. Hopefully merged. Code is coming along, we are just ironing out the edge cases with error codes.

[melvin-bot]

@blimpich, @MitchExpensify, @ikevin127, @allgandalf Still overdue 6 days?! Let's take care of this!

[allgandalf]

@blimpich and @MelvinBot are exchanging the overdue label 😆

[allgandalf]

@ikevin127 please start with the PR review, the Auth PR should get deployed to production today/ tomorrow, do keep the use staging server option toggled on

[blimpich]

Backend changes were deployed the production a few hours ago, so shouldn't need to use the use staging server option anymore 👍

[ikevin127]

🧪 Here’s what I plan to test regarding the PR based on design doc:

• verify the new feature is behind beta (canUsePrivateDomainCheck)
• on signup, verify public domain check (both email and phone [phones always public domain]) via isFromPublicDomain and if true -> show new private domain onboarding screen
• on new onboarding flow screen, verify that user is asked for work email
• verify that Skip button exists, which checks whether user comes from OD and if their signupQualifier is VSB then navigate the user to Accounting Onboarding Page
• verify that when user will press “Add work email” we validate to check for valid private domain email
• on mobile devices (mWeb / Native), verify there’s no autoFocus on the Work Email input
• next, verify whether work email is tied to an existing account then skip magic code, otherwise request magic code
• verify that there’s an option to Skip the magic code validation, which won’t save the private domain email as contact method in user profile, continuing with the onboarding flow
• verify that when MergeIntoAccountAndLogin fails and it’s not related to magic code validation, we display the “Merging blocked” screen on which if user clicks “Got it”, we’ll move forward with the onboarding flow
• depending on whether the private domain was validated or not, if the shouldRedirectToClassicAfterMerge NVP value is true we redirect the user to OD, otherwise continue with current ND onboarding flow

Note

Will start testing once author will open the PR for review, as they are still working on it based on #54186 (comment).

@allgandalf Should all these tests pass on the frontend PR, or this PR is strictly FE (no data persisted) and we're going to have a follow-up integration PR where the feature will be fully completed ?

[melvin-bot]

@blimpich, @MitchExpensify, @ikevin127, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!