[HOLD for payment 2025-02-04] [$250] Delete Receipt button is not displayed in merged transaction

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.74-0

Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): tester+mergetests@applausecard.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Action Performed:

Preconditions: A user has a Expensify Card transaction and the receipt to do a merge between the 2.

The account tester+mergetests@applausecard.expensifail.com is setup to test this.

1. Log in with tester+mergetests@applausecard.expensifail.com
2. Upload the following receipt to the WS chat
3. Wait for the Smartscan
4. After the transactions have been merged - Navigate to the expense conversation
5. Open the receipt
6. Click on the 3 dot menu in the preview

Expected Result:

There should be a Delete receipt (or detach) receipt option as there is in OldDot. After the receipt is deleted it should fallback to the eReceipt.

Actual Result:

There's no option to delete (or detach) the receipt like in OldDot.

Workaround:

User can detach the receipt via OldDot.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• [] MacOS: Desktop

Screenshots/Videos

Untitled.video.5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021867328664713695509
• Upwork Job ID: 1867328664713695509
• Last Price Increase: 2024-12-19
• Automatic offers:
• dominictb | Reviewer | 105403297

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jliexpensify]

@joekaufmanexpensify @robertjchen @luacmartins hello - would this be a new feature? Is there a C+ that's currently working on this?

[joekaufmanexpensify]

Not familiar with this flow, but seems like this bug came from an applause issue where we asked them to create regression tests, so I'm thinking this is in fact a bug

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021867328664713695509

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

[jliexpensify]

Thanks Joe!

[isagoico]

@joekaufmanexpensify @jliexpensify Hi there! This issue came up when I was writing tests for the merge transaction feature. I checked the behavior on OD and in ND and it seems ND is missing the detach receipt/delete receipt option. Had a discussion with @trjExpensify and @mountiny around this and seems it's either a missing feature or a bug.

[joekaufmanexpensify]

Cool. TY!

[melvin-bot]

@jliexpensify, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dominictb]

Waiting for proposals.

[trjExpensify]

To clarify the expectation here, do we agree on the below?

• We only use "Delete receipt" terminology in NewDot, not "Detach receipt". ("Replace receipt" is a different button).
• If there was an eReceipt attached prior to the merge, clicking Delete receipt would revert to show the eReceipt.
• If there was not an eReceipt attached prior to the merge, clicking Delete receipt will just remove the user's receipt.

CC: @JmillsExpensify for eyes on this as well.

[JmillsExpensify]

I agree with all that. Let's definitely try to get away from this pretty heavy way of doing things that OldDot does around Detach receipt – especially since a receipt becomes an attachment at that point. If someone wanted to add an attachment that could have done that in the comment thread to begin with.

[trjExpensify]

Kewl, works for me!

[dominictb]

@jliexpensify I wonder if expert contributors could reproduce card transaction issues. If so we need one here. Because normal contributors cannot.

[jliexpensify]

By expert contributors - do you mean someone from one of the agencies? @mountiny - is there someone you have in mind that you can recommend?

Also, just a heads up that I am OOO until the 29th - I'm happy to keep this assigned to myself, but I'll add someone else from the BugZero team to help push this along in the interim.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

Hard for me to tell from the proposal but in general it looks good

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Delete Receipt button is not displayed in merged transaction #55474

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @rinej does not require payment (Contractor)
• @dukenv0307 requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Reviewer)

[melvin-bot]

@dukenv0307 / @dominictb @jliexpensify @dukenv0307 / @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in https://app.slack.com/client/E047TPA624F/C01GTK53T8Q has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Submit a card transaction expense
2. A Paypal receipt is sent to your email (titled Your PayPal receipt)
3. Submit a scan expense using the above receipt
4. Wait for the above expenses (scan & card) to be merged
5. Open the merged expense report
6. Open the receipt
7. Press the 3-dot menu
8. Verify Delete receipt appears
9. Press Delete receipt
10. Verify it reverts to show the card eReceipt (instead of the Paypal receipt photo you updated previously)

Do we agree 👍 or 👎

[jliexpensify]

Payment Summary

• C: @dominictb $250 (to be paid via Upworks)
• C+: @dukenv0307 $250 (to be paid vis ND)

[jliexpensify]

@dominictb the previous Upworks job closed, can you accept this one? https://www.upwork.com/jobs/~021886615380373019169

Thanks!

[jliexpensify]

Bumping @dominictb to accept in Upworks so I can pay + close!

[dominictb]

@jliexpensify Accepted, thank you 🙇

[jliexpensify]

Paid and job closed.

@dukenv0307 please refer to this summary.

[JmillsExpensify]

$250 approved for @dukenv0307