[$500] Hybrid - Bank account - App crashes when Onfido screen shows up #51865
Comments
lanitochka17
added
Daily
|
Triggered auto assignment to @adelekennedy ( |
|
@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
|
@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
|
hmmm I'm struggling to reproduce on browserstack but that may be user error, asking for a buddy check |
|
@adelekennedy Eep! 4 days overdue now. Issues have feelings too... |
adelekennedy
added
the
External
|
Job added to Upwork: https://www.upwork.com/jobs/~021856252175272588482 |
melvin-bot
bot
changed the title
melvin-bot
bot
added
the
Help Wanted
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
|
@Ollyws @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
|
@Ollyws, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
|
@Ollyws, @adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
|
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
|
Still awaiting proposals... |
|
@Ollyws, @adelekennedy Eep! 4 days overdue now. Issues have feelings too... |
|
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
|
@Ollyws, @adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
|
@Ollyws @adelekennedy this issue is now 4 weeks old, please consider:
Thanks! |
|
@Ollyws, @adelekennedy Eep! 4 days overdue now. Issues have feelings too... |
|
@Ollyws, @adelekennedy 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
|
Do you have to set the NVP to reproduce this? It seems pretty niche |
|
I'm going to make it MEDIUM but if we think this is worse than that, please let me know |
|
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
ProposalPlease re-state the problem that we are trying to solve in this issue.App crashes when Onfido screen shows up What is the root cause of that problem?When we initialize Onfido process, we see 2 errors java.lang.RuntimeException: Unable to create service com.onfido.android.sdk.capture.ui.OnfidoStarterService: java.lang.IllegalStateException: Can't set data directory suffix: WebView already initializedjava.lang.IllegalStateException: Default FirebaseApp is not initialized in this process org.me.mobiexpensifyg.dev:onfido_process. Make sure to call FirebaseApp.initializeApp(Context) first.What changes do you think we should make in order to solve the problem?To fix the errors, we need to stop re-initialization of views which are unnecessary in onfido process. For that, we will add the conditional to early return when the process is Code private boolean isOnfidoProcess(Context context) {
int currentPid = Process.myPid();
ActivityManager manager = (ActivityManager) context.getSystemService(Context.ACTIVITY_SERVICE);
for (ActivityManager.RunningAppProcessInfo processInfo : manager.getRunningAppProcesses()) {
if (processInfo.pid == currentPid) {
return processInfo.processName.endsWith(":onfido_process");
}
}
return false;
}For fixing Firebase error, we will use ResultScreen.Recording.2025-01-21.at.10.36.30.PM.movWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?NA since this change is related to HybridApp. What alternative solutions did you explore? (Optional) |
|
@Ollyws I discussed this solution with @mateuuszzzzz, and he seems to be fine with the approach. |
|
@Ollyws is on it for review, melvin |
|
@shubham1206agra's proposal LGTM. |
|
Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
melvin-bot
bot
removed
the
Help Wanted
|
📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
|
PR is up for review. https://github.com/Expensify/Mobile-Expensify/pull/13381 |
|
@Ollyws, @thienlnam, @shubham1206agra, @adelekennedy Huh... This is 4 days overdue. Who can take care of this? |
|
looks like the PR has been merged and closed? |
|
@adelekennedy PR is on production now. |
|
@Ollyws, @thienlnam, @shubham1206agra, @adelekennedy Still overdue 6 days?! Let's take care of this! |
|
@Ollyws, @thienlnam, @shubham1206agra, @adelekennedy 10 days overdue. I'm getting more depressed than Marvin. |
|
@adelekennedy This was fixed with https://github.com/Expensify/Mobile-Expensify/pull/13381. Can you prepare for payment? |
adelekennedy
added
the
Awaiting Payment
|
Payment due 02/10/25 |
|
@Ollyws, @thienlnam, @shubham1206agra, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.56-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5170744
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
App works fine
Actual Result:
App crashes
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6652056_1730454634072.Screen_Recording_20241101_123745.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @adelekennedyThe text was updated successfully, but these errors were encountered: