Skip to content

Commit ebcef15

Browse files
mountinyOSBotify
authored andcommitted
Merge pull request #75219 from Expensify/revert-66793-Guccio163/expo-video
[CP Staging] Revert "Expo-av to expo-video migration" (cherry picked from commit 930127c) (cherry-picked to staging by mountiny)
1 parent 8ce83f5 commit ebcef15

33 files changed

+746
-767
lines changed

__mocks__/expo-video.tsx

Lines changed: 0 additions & 114 deletions
This file was deleted.

config/webpack/webpack.common.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ const includeModules = [
4646
'@react-native/assets',
4747
'expo',
4848
'expo-av',
49-
'expo-video',
5049
'expo-image-manipulator',
5150
'expo-modules-core',
5251
].join('|');

cspell.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,6 @@
698698
"unhold",
699699
"Unlaminated",
700700
"Unmigrated",
701-
"unmuting",
702701
"unredacted",
703702
"unscrollable",
704703
"unsubmitted",

package-lock.json

Lines changed: 0 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@
144144
"expo-image-manipulator": "^13.1.5",
145145
"expo-modules-core": "3.0.18",
146146
"expo-secure-store": "~14.2.4",
147-
"expo-video": "^3.0.11",
148147
"fast-equals": "^5.2.2",
149148
"focus-trap-react": "^11.0.3",
150149
"group-ib-fp": "file:modules/group-ib-fp",

patches/expo-av/details.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# `expo-av` patches
2+
3+
### [expo-av+15.1.7+001+fix-blank-screen-android.patch](expo-av+15.1.7+001+fix-blank-screen-android.patch)
4+
5+
- Reason:
6+
7+
```
8+
This patch fixes blank modal after fullscreen video ends on Android.
9+
```
10+
11+
- Upstream PR/issue: The maintainer of the upstream lib isn't willing to accept fix for the lib because it's going to be replaced by another lib `expo-video`, see comment https://github.com/expo/expo/issues/19039#issuecomment-2688369708
12+
- E/App issue: https://github.com/Expensify/App/issues/53904
13+
- PR introducing patch: https://github.com/Expensify/App/pull/56302
14+
15+
16+
### [expo-av+15.1.7+002+handle-unsupported-videos-ios.patch](expo-av+15.1.7+002+handle-unsupported-videos-ios.patch)
17+
18+
- Reason:
19+
20+
```
21+
This patch handles unsupported videos in iOS.
22+
```
23+
24+
- Upstream PR/issue: Probably same reason as the first patch.
25+
- E/App issue: https://github.com/Expensify/App/issues/52673
26+
- PR introducing patch: https://github.com/Expensify/App/pull/57353

0 commit comments

Comments
 (0)