Springboot 3.5.0 compatibility issue

[WoongE]

Hello. I found an issue while upgrading to springboot 3.5.0.

Springboot 3.5.0 uses graphql-java:24.0 and java-dataloader:5.0.0

With the introduction of jspecify, IDEs started throwing errors that didn't exist before.

In this version, Any? inheritance for the Value type of DataLoader is no longer available. You must explicitly inherit from Any.

The current code is no longer suitable.

But, I believe that developers should be able to choose whether the result type of DataLoader is nullable or non-null.

I think graphql-java should be,

// current
@NullMarked
public class DataLoader<K, V>

// I hope
@NullMarked
public class DataLoader<K, @Nullable V>

For now, I am temporarily using @Suppress("UPPER_BOUND_VIOLATED") to ignore the issue.

[marvinelsen]

We are facing the same issue.

[wakita181009]

I'm facing the issue on Spring Boot 3.5.x, too. Is there any update on the issue?

[WoongE]

@marvinelsen @wakita181009

Hello. I am using the @Suppress annotation to ignore the issue temporarily.

Use @Suppress("UPPER_BOUND_VIOLATED_BASED_ON_JAVA_ANNOTATIONS") or @Suppress("UPPER_BOUND_VIOLATED") depends on your Kotlin version.

For example, I am using it like this.

abstract class KotlinMappedDataLoader<K, V> : KotlinDataLoader<K, V> {
    override val dataLoaderName: String = this::class.getDataLoaderName()

    open val optionBuilder: DataLoaderOptions.Builder.() -> Unit get() = { setCachingEnabled(false) }

    abstract fun load(graphQLContext: GraphQLContext, ids: Set<K>): Map<K, V>

    @Suppress("UPPER_BOUND_VIOLATED_BASED_ON_JAVA_ANNOTATIONS") // or @Suppress("UPPER_BOUND_VIOLATED")
    override fun getDataLoader(graphQLContext: GraphQLContext): DataLoader<K, V> =
        DataLoaderFactory.newMappedDataLoader(dataLoaderName, { ids ->
            VirtualThreadExecutor.async { load(graphQLContext, ids) }
        }, DataLoaderOptions.Builder().apply(optionBuilder).build())

    companion object {
        fun KClass<out KotlinMappedDataLoader<*, *>>.getDataLoaderName(): String =
            simpleName ?: error("Cannot load dataLoaderClass's simpleName.")
    }
}

@Component
class UserAddressDataLoader(
    private val queryContract: UserAddressQueryContract,
) : KotlinMappedDataLoader<ID, List<UserAddressGraph>>() {
    override fun load(graphQLContext: GraphQLContext, ids: Set<ID>): Map<ID, List<UserAddressGraph>> {
        val userIds = ids.map { it.toLong() }.distinct()
        val userIdUserAddressesMap = queryContract
            .getByUserIds(userIds)
            .map { UserAddressGraph.of(it) }
            .groupBy { it.userId }
        return ids.associateWith { userIdUserAddressesMap[it].orEmpty() }
    }
}