Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

units are almost entirely undocumented, everywhere #63

Open
ExpHP opened this issue Aug 27, 2018 · 1 comment
Open

units are almost entirely undocumented, everywhere #63

ExpHP opened this issue Aug 27, 2018 · 1 comment

Comments

@ExpHP
Copy link
Owner

ExpHP commented Aug 27, 2018

I seldom bother documenting units because I've always wanted to use newtypes for units. However, those are such a hassle to adopt, and I should probably just face the facts that it's never going to happen.

It feels ironic that rsp2 already even has newtypes for some things like Mass, and that even these do not specify what the units are.

@ExpHP
Copy link
Owner Author

ExpHP commented Aug 27, 2018

For the record, except where noted:

  • All masses are atomic units
  • All frequencies are wavenumber (cm^-1)
  • All cartesian coordinates are Angstrom
  • All energies are eV
  • All reciprocal cartesian coordinates are Angstrom^-1
    • rsp2 defines the reciprocal lattice as inv(L^T), without a 2pi factor (to any power). This similarly affects k vectors. Rather, the 2pi factors appear in phase factors (usually written in the form exp(i * 2 * pi * dot(k, x))).
  • Angles are almost always in radians, however, degrees are usually used for display purposes and input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant