Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ FEATURE ] set API max retry #262

Open
gdjohn4s opened this issue Sep 14, 2023 · 5 comments
Open

[ FEATURE ] set API max retry #262

gdjohn4s opened this issue Sep 14, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gdjohn4s
Copy link
Member

Is your feature request related to a problem? Please describe

No, but for a possible future problem like DDOS.

Describe the solution you'd like

I'd like to set a max retry per user session.

Additional context

This is a possible way to implement it in settings.py:

'DEFAULT_THROTTLE_RATES': {
        'anon': '100/day',
        'user': '1000/day'
    }
@gdjohn4s gdjohn4s added enhancement New feature or request good first issue Good for newcomers labels Sep 14, 2023
@Dev79844
Copy link

Hey @gdjohn4s! I would like to work on this issue.

@FlavioAdamo
Copy link
Member

FlavioAdamo commented Sep 18, 2023

hI @Dev79844 , sure!
I think a good limit would be 100 requests per hour for not logged users, and 1000 for logged in users.

@gdjohn4s wdyt?

@gdjohn4s
Copy link
Member Author

sure

@Dev79844
Copy link

@gdjohn4s I am getting this error while setting up the application locally. Can help me?
Screenshot 2023-09-21 at 2 44 04 PM

@gdjohn4s
Copy link
Member Author

@Dev79844 Try removing the versioning and use only distro-info in the requirements

@Dev79844 Dev79844 mentioned this issue Oct 2, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants