style: lint all packages and modifying eslint rules

Author: Lucas

.eslintrc.json

@@ -32,14 +32,18 @@
         // PropType.Shape seems buggy
         "react/no-unused-prop-types": [2, { "skipShapeProps": true }],
         "import/extensions" : 0,
-        "import/no-unresolved": [2, {
-            "ignore": [
-                // App dependancies, as global modules
-                "__app_modules__",
-                // Peer dependancies
-                "react",
-                "react-dom"
-            ]
-        } ]
+        "import/no-extraneous-dependencies": 0,
+        "import/no-unresolved": 0,
+        "function-paren-newline": [2, "consistent"],
+        "object-curly-newline": [2, {
+            "consistent": true
+        }],
+        "comma-dangle": [2, {
+            "arrays": "always-multiline",
+            "objects": "always-multiline",
+            "imports": "always-multiline",
+            "exports": "always-multiline",
+            "functions": "never"
+        }]
     }
 }

packages/vitaminjs-build/bin/vitamin.js

@@ -134,7 +134,7 @@ const build = (options, hotCallback, restartServer) => (options.hot ?
         hotCallback,
         restartServer,
     )
-:
+    :
     commonBuild(webpackConfigClient, 'client bundle(s)', options)
         .then(({ buildStats }) => commonBuild(
             webpackConfigServer, 'server bundle...',
@@ -263,8 +263,7 @@ program
                 }
                 process.exit(1);
             });
-        }
-    );
+    });
 
 program
     .command('clean')
@@ -286,8 +285,7 @@ program
                     console.log(err.stack || err);
                 }
                 process.exit(1);
-            }),
-    );
+            }));
 
 program
     .command('serve')

packages/vitaminjs-build/config/build/webpack.config.client.js

@@ -32,7 +32,7 @@ module.exports = function clientConfig(options) {
             options.hot && new webpack.NoEmitOnErrorsPlugin(),
             !options.dev && new webpack.optimize.UglifyJsPlugin({
                 sourceMap: options.withSourceMaps,
-                minimize: true
+                minimize: true,
             }),
             options.client.serviceWorker && new ServiceWorkerWebpackPlugin({
                 // FIXME Move resolving with other config props
@@ -47,4 +47,4 @@ module.exports = function clientConfig(options) {
             module: 'empty',
         },
     }, concat);
-}
+};

packages/vitaminjs-build/config/build/webpack.config.common.js

@@ -18,16 +18,16 @@ function createBabelLoader(env, options) {
     return {
         test: /\.js(x?)$/,
         loader: 'babel-loader',
-        include: path => {
+        include: path =>
             // We only want to transpile user land application code and our own runtime
-            return (
+            (
                 !isExternalModulePath(path) ||
                 __isVitaminFacadeModulePath(path) ||
                 isRuntimeModulePath(path) ||
-                // FIXME This is only required for parts of the runtime that require the build system
+                // FIXME This is only required for parts of the runtime
+                // that require the build system
                 isBuildModulePath(path)
-            );
-        },
+            ),
         query: babelrc(env, options),
     };
 }
@@ -112,7 +112,7 @@ function config(options) {
         resolve: {
             alias: {
                 ...options.moduleMap,
-                '__vitamin_runtime_config__': require.resolve('../runtimeConfig'),
+                __vitamin_runtime_config__: require.resolve('../runtimeConfig'),
             },
             // Commmented out beause absolute paths were opting out of node resolve algorithm
             // modules: MODULES_DIRECTORIES,

packages/vitaminjs-build/config/build/webpack.config.server.js

@@ -25,7 +25,7 @@ function externals(context, request, callback) {
         !__hasWebpackLoader(request)
     ) {
         // FIXME Why commonjs2 over commonjs
-        callback(null, 'commonjs2 ' + request);
+        callback(null, `commonjs2 + ${request}`);
         return;
     }
 
@@ -77,4 +77,4 @@ module.exports = function serverConfig(options) {
             }),
         ].filter(Boolean),
     }, concat);
-}
+};

packages/vitaminjs-build/config/build/webpack.config.tests.js

@@ -24,4 +24,4 @@ module.exports = function testConfig(options) {
             'react/lib/ReactContext': true,
         },
     }, concat);
-}
+};

packages/vitaminjs-build/config/index.js

@@ -85,7 +85,8 @@ function loadExtendedConfig(config, configPath) {
 }
 
 
-const rcPath = exports.rcPath = resolveRcPath();
+const rcPath = resolveRcPath();
+exports.rcPath = rcPath;
 
 exports.default = () => {
     let config = loadConfigFile(rcPath);
@@ -119,16 +120,16 @@ exports.default = () => {
     const moduleMap = getModuleMap(modulePaths);
 
     // Cleanify config export by removing module paths
-    modulePaths.forEach(path =>
-        deletePath(path, config),
+    modulePaths.forEach(
+        path => deletePath(path, config)
     );
 
     // Resolve app path to absolute paths
     [
         ['server', 'buildPath'],
         ['client', 'buildPath'],
-    ].forEach(path =>
-        updatePath(path, resolveConfigPath, config),
+    ].forEach(
+        path => updatePath(path, resolveConfigPath, config),
     );
 
     // Prepend / to publicPath and basePath if necessary

packages/vitaminjs-build/config/resolve.js

@@ -14,21 +14,6 @@ function resolveModule(id, basedir) {
     return resolve.sync(id, { basedir, extensions: ['.js', '.jsx'] });
 }
 
-function resolveConfigModule(id) {
-    // This is used in a context with the following dependency graph:
-    //      app -> vitaminjs
-    //      vitaminjs -> vitaminjs-build
-    //      vitaminjs -> vitaminjs-runtime -> vitaminjs-build
-    // So runtime package resolving will not always be relative to the app
-    // (where the .vitaminrc file is located). We try resolve the runtime
-    // package by walking up the dependency tree.
-    if (id.startsWith('__vitamin_runtime__/')) {
-        return resolveParentModule(id.replace('__vitamin_runtime__', 'vitaminjs-runtime'));
-    }
-    // .vitaminrc relative resolution
-    return resolveModule(id, dirname(resolveRcPath()));
-}
-
 // FIXME Consider not exporting this function anymore but use webpack's "context" config
 function resolveParentModule(id) {
     // Sample node modules paths for 'vitaminjs-runtime/src/server/components/HTMLLayout',
@@ -56,6 +41,21 @@ function resolveParentModule(id) {
     return resolveModule(id, basedir);
 }
 
+function resolveConfigModule(id) {
+    // This is used in a context with the following dependency graph:
+    //      app -> vitaminjs
+    //      vitaminjs -> vitaminjs-build
+    //      vitaminjs -> vitaminjs-runtime -> vitaminjs-build
+    // So runtime package resolving will not always be relative to the app
+    // (where the .vitaminrc file is located). We try resolve the runtime
+    // package by walking up the dependency tree.
+    if (id.startsWith('__vitamin_runtime__/')) {
+        return resolveParentModule(id.replace('__vitamin_runtime__', 'vitaminjs-runtime'));
+    }
+    // .vitaminrc relative resolution
+    return resolveModule(id, dirname(resolveRcPath()));
+}
+
 function isExternalModulePath(path) {
     // There is a theoretical edge case when the application is contained in a
     // parent directory called "node_modules". In that case any internal
@@ -74,6 +74,7 @@ function isExternalModule(id) {
     return !INTERNAL_REGEXP.test(id);
 }
 
+// eslint-disable-next-line no-unused-vars
 function isRuntimeModule(id, basedir) {
     // FIXME
     return /vitaminjs-runtime/.test(id);

packages/vitaminjs-runtime/src/server/middlewares/router.js

@@ -5,13 +5,14 @@ import routes from '__app_modules__routes__';
 const routesWithStore = typeof routes === 'function' ? store => routes(store) : () => routes;
 
 export default () => async (ctx, next) => {
-    const url = ctx.req.url;
-    const history = ctx.state.history;
+    const { url } = ctx.req;
+    const { history } = ctx.state;
 
     const appRoutes = await routesWithStore(ctx.state.store);
 
     await new Promise((resolve, reject) => {
-        match({ routes: appRoutes, location: url, history },
+        match(
+            { routes: appRoutes, location: url, history },
             (error, redirectLocation, renderProps) => {
                 if (error) {
                     reject(error);

packages/vitaminjs-runtime/src/server/server.js

@@ -1,4 +1,4 @@
-/* eslint-disable global-require, no-console */
+/* eslint-disable indent,global-require,no-console */
 
 import { parse as parseUrl } from 'url';
 import Koa from 'koa';
@@ -8,8 +8,8 @@ import fetch from 'node-fetch';
 import readline from 'readline';
 import httpGracefulShutdown from 'http-graceful-shutdown';
 
-import appMiddleware from './appMiddleware';
 import config from '__vitamin_runtime_config__';
+import appMiddleware from './appMiddleware';
 
 global.fetch = fetch;
 
@@ -49,7 +49,8 @@ if (process.env.NODE_ENV !== 'production' && module.hot) {
                     return;
                 }
                 clientBuilt = true;
-                process.stdout.write(`\x1b[0G${chalk.green('\u2713')
+                process.stdout.write(
+                    `\x1b[0G${chalk.green('\u2713')
                     } Client bundle(s) successfully ${chalk.bold('built in memory')}\n\n`,
                 );
             },