Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The React Europe Conference source does not seem web ready #5

Open
SynerG opened this issue Jul 17, 2019 · 1 comment
Open

The React Europe Conference source does not seem web ready #5

SynerG opened this issue Jul 17, 2019 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@SynerG
Copy link

SynerG commented Jul 17, 2019

The 'React Europe Conference App' website works fine and looks like a great example of RNW/Expo Web development.
However, the source code linked in the repo does not seem web-ready.
Its app.json only mentions android and ios, not web.
Cloning that repo, installing dependencies and running expo start --web does not work for me. It spits multiple errors as it tries to bundle react-native libraries.

I guess that the web version had changes that are not committed to the github repo.

It is a pity as I was trying to find an example of a comprehensive RN web app (not a game) that included navigation.
(The Instagram clone would also be a good example, but does not include source code).

I would open an issue in that repo asking if they could commit the changes to make it web compatible, but the repo does not allow to open issues.

Are you aware of how to run the source code on web? Maybe the readme of this repo could include some tips

@EvanBacon
Copy link
Owner

I guess that the web version had changes that are not committed to the github repo.

Right, I need to PR the changes in. Unfortunately things are changing a lot with Expo web beta (which makes most of this possible).

(The Instagram clone would also be a good example, but does not include source code).

Will publish.

(not a game) that included navigation.

Lol sorry 😅 please feel free to find and link some, I only know about them if someone tells me.

@EvanBacon EvanBacon self-assigned this Aug 2, 2019
@EvanBacon EvanBacon added the question Further information is requested label Aug 2, 2019
EvanBacon added a commit that referenced this issue Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants