Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenient interface to mask pixels in detector data #308

Closed
philsmt opened this issue May 4, 2022 · 4 comments
Closed

Add convenient interface to mask pixels in detector data #308

philsmt opened this issue May 4, 2022 · 4 comments

Comments

@philsmt
Copy link
Contributor

philsmt commented May 4, 2022

Just came up in the detector calibration round, some users find it difficult to apply the bad pixels masks produced (e.g. in the offline correction system). The BadPixels enum will be added as part of the CorrectionData interface, and we should make sure there are easy ways to set individual bits and/or retrieve the data already in such a way.

@D4vidH4mm3r
Copy link

Dropping some (sorry, internal) links to relevant discussions:

As for making it easy to select which fields to apply: Maybe we provide some preset groups? For example one from dark characterization, we'd have a group of OFFSET_OUT_OF_THRESHOLD | NOISE_OUT_OF_THRESHOLD | OFFSET_NOISE_EVAL_ERROR | NO_DARK_DATA.

@JamesWrigley
Copy link
Member

Related: #146.

@takluyver
Copy link
Member

I'm tempted to say it's a duplicate of #146. 🙂

@philsmt
Copy link
Contributor Author

philsmt commented May 4, 2022

Fine by me, but let's keep the mentioning of an easy interface for flipping bits on and off. Working with bit flags can be quite unintuitive, so it should be part of any API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants