-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a value doesn't exist in the replacement dictionary and it is referenced in an optional variable, it breaks all optional variables after #508
Comments
@shoe913, i reproduced this the first time i deployed the solution to the org, but it worked properly the 2nd time and I can no longer repro. Are you seeing the same. Does your org have a shared theme logo, this is different from the org logo at the top of the settings. |
After ensuring I had the logo in the correct place, it did start to work. I still think we need to look into this though because I made no changes to the org name, and that did not swizzle until the image was swizzeling. I think it is quite possible we have users who haven't set the shared image, but do want the org name copied. |
@shoe913, could you narrow it down then. Is this true that orgs w/o the shared theme logo fail? My understanding is they shouldn't have anything to do with each other. I want to get to the consistent simplest repro case before we pass along. |
I can no longer reproduce this with my current orgs. However, when I create a trial org, I can consistently repro. It seems that the shared logo is changing a few things. Before Logo Added (trial with all defaults):
After Logo Added (same trial, only add the logo):
After Logo Removed (same trial, remove the shared logo:
|
@MikeTschudi, I was able to create a really simple repro case for this. Here are the steps:
What it looks like is happening, is the first {{organization.name||My Community}} is replaced properly with the organization name setting. When it gets to the second it can't find organization.nonexistantproperty.sharedTheme.logo.small in the replacement dictionary, so it correctly falls back to https://www.arcgis.com/sharing/rest/content/items/28989a5ecc2d4b2fbf62ac0f5075b7ff/data. Then the third one, should be properly replaced with the org name again, but it instead it is returning the name of the variable incorrectly. |
Superb information; thank you @shoe913 & @chris-fox! adlib library appears to stop after a failed lookup: Esri/adlib#53 |
fixed adlib: Esri/adlib#54 |
adlib updated to version 3.0.6; hub.js needs update to use same version |
Verified |
Organization variables (like the ones below) are not swapped out when the target organization does not have Hub Premium.
{{organization.name||My Organization}}
{{organization.portalProperties.sharedTheme.logo.small||https://www.arcgis.com/sharing/rest/content/items/28989a5ecc2d4b2fbf62ac0f5075b7ff/data}}
The text was updated successfully, but these errors were encountered: