Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile directly reassigns CSS variables within the component #9278

Closed
2 tasks done
alisonailea opened this issue May 7, 2024 · 2 comments
Closed
2 tasks done

Tile directly reassigns CSS variables within the component #9278

alisonailea opened this issue May 7, 2024 · 2 comments
Assignees
@alisonailea
Labels
2 - in development Issues that are actively being worked on. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-05-28 - May ...

Comments

@alisonailea
Copy link
Contributor

alisonailea commented May 7, 2024 •
edited

Check existing issues

Actual Behavior

Tile component tokens as CSS can not be reassigned by users because the tokens are directly assigned within the component.

Expected Behavior

As a user I should be able to give each component token new values and have those take precedence over the internal token assignments, including for classes and states

Reproduction Sample

https://codepen.io/alisonailea/pen/yLWBXbq/c1ce40abeafb2210def6108a2b745c5f

Reproduction Steps

  1. open the link
  2. observe the tile that has the class ".selected"
  3. notice the border is still blue and not red

Reproduction Version

2.8.1-next.3

Relevant Info

No response

Regression?

No response

Priority impact

p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components

Esri team

Calcite (design)
@alisonailea alisonailea added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 7, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone Calcite (design) Issues logged by Calcite designers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. labels May 7, 2024
@alisonailea alisonailea self-assigned this May 7, 2024
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 7, 2024
@alisonailea alisonailea mentioned this issue May 7, 2024
Closed
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels May 7, 2024
@geospatialem
Copy link
Member

@alisonailea Would the above also be closed in favor of #7180 per #9279 (comment)?

@geospatialem
Copy link
Member

Closing in favor of #7180 as discussed in the team mid-milestone discussion and mentioned in the comment above on 5/13. cc @alisonailea

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alisonailea alisonailea

Labels
2 - in development Issues that are actively being worked on. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
2 participants
@alisonailea @geospatialem