-
Notifications
You must be signed in to change notification settings - Fork 88
[Action Bar] Deprecate expandDisabled and replace with expandToggleDisabled #14695
Copy link
Copy link
Open
Labels
Calcite (dev)Issues logged by Calcite developers.Issues logged by Calcite developers.c-action-barIssues that pertain to the calcite-action-bar componentIssues that pertain to the calcite-action-bar componentcalcite-componentsIssues specific to the @esri/calcite-components package.Issues specific to the @esri/calcite-components package.estimate - 3A day or two of work, likely requires updates to tests.A day or two of work, likely requires updates to tests.future breaking changeIssues and pull requests with deprecation(s), requires a breaking change in a future milestone.Issues and pull requests with deprecation(s), requires a breaking change in a future milestone.impact - p2 - want for an upcoming milestoneUser set priority impact status of p2 - want for an upcoming milestoneUser set priority impact status of p2 - want for an upcoming milestonep - mediumIssue is non core or affecting less that 60% of people using the libraryIssue is non core or affecting less that 60% of people using the libraryrefactorIssues tied to code that needs to be significantly reworked.Issues tied to code that needs to be significantly reworked.
Milestone
Description
Metadata
Metadata
Assignees
Labels
Calcite (dev)Issues logged by Calcite developers.Issues logged by Calcite developers.c-action-barIssues that pertain to the calcite-action-bar componentIssues that pertain to the calcite-action-bar componentcalcite-componentsIssues specific to the @esri/calcite-components package.Issues specific to the @esri/calcite-components package.estimate - 3A day or two of work, likely requires updates to tests.A day or two of work, likely requires updates to tests.future breaking changeIssues and pull requests with deprecation(s), requires a breaking change in a future milestone.Issues and pull requests with deprecation(s), requires a breaking change in a future milestone.impact - p2 - want for an upcoming milestoneUser set priority impact status of p2 - want for an upcoming milestoneUser set priority impact status of p2 - want for an upcoming milestonep - mediumIssue is non core or affecting less that 60% of people using the libraryIssue is non core or affecting less that 60% of people using the libraryrefactorIssues tied to code that needs to be significantly reworked.Issues tied to code that needs to be significantly reworked.
Type
Fields
Give feedbackNo fields configured for issues without a type.
monday.com sync: #12366231128
Check existing issues
Which Component
Action Bar
Description
Action Bar's
expandDisabledproperty should be deprecated and replaced (renamed) byexpandToggleDisabled.This change is helpful because the name of the
expandDisabledproperty causes confusion in two ways:expandDisabledis set, expand toggling can still happen based on layout changes. The property actually hides a UX element.expandedproperty, as whenexpandDisabledis set it seems backwards to the user to think they would still need theexpandedproperty, as they just disabled it.Acceptance Criteria
expandToggleDisabledproperty is created, replacing the behavior ofexpandDisabled.expandDisabledproperty is deprecated, with an issue created upon its deprecation to remove it.Relevant Info
Originated from discussion in #14589
Example Use Case
No response
Priority impact
impact - p2 - want for an upcoming milestone
Calcite package
Esri team
Calcite (dev)