Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace POST with GET #10

Open
EricRibeiro opened this issue Aug 30, 2022 · 1 comment
Open

Replace POST with GET #10

EricRibeiro opened this issue Aug 30, 2022 · 1 comment

Comments

@EricRibeiro
Copy link
Owner

Motivation

Semantically, requesting via GET makes more sense than POST. The latter can be justified if data is persisted. Since it is not the case, GET should be used instead.

Expected Behaviour

The GET method in /mortgage should invoke the calculate function.
@nakul-chawla
Copy link

#11

Kindly have a look at this PR.
Help me understand more things that could be added to POST endpoint.
And let me know if I understood the issue correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EricRibeiro @nakul-chawla