Change 'unwrap' usage to '?' operator in controller/src/command.rs #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
who-biz
force-pushed
the
controller-dont-use-unwrap
branch
from
a8c332b to
35584a7
Compare
|
Reverted changes that pertain to |
skykingisepic
approved these changes
Dec 21, 2023
johanneshahn
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usage of
?operator was removed, and replaced withunwrap()which will panic if operation fails.These changes were originally made in tokio, hyper, etc update in #95
Purpose of this PR is just a reversion of these, to avoid panics in tx flow.