Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WCAG2.1 accessible tool #2390

Open
Eonasdan opened this issue Sep 3, 2021 · 14 comments
Open

Support WCAG2.1 accessible tool #2390

Eonasdan opened this issue Sep 3, 2021 · 14 comments
Labels
State: planned This ticket is planned to be worked on. State: Sponsored Type: Feature Request
Milestone
7.0

Comments

@Eonasdan
Copy link
Owner

Eonasdan commented Sep 3, 2021

Hi @Eonasdan, I have checked docs but couldn't find anything related. Is v6 will support WCAG2.1? In other words will it be an accessible tool?

Originally posted by @kiliczsh in #2384 (comment)
@Eonasdan Eonasdan added help wanted State: Triage Tickets that need to be triaged. labels Sep 3, 2021
@Eonasdan
Copy link
Owner Author

Eonasdan commented Sep 3, 2021

@kiliczsh The icons have title attributes but I haven't done much with accessibility. That's a good idea though.

@Eonasdan Eonasdan mentioned this issue Dec 17, 2021
Closed
@SanjayBhargavS SanjayBhargavS mentioned this issue Jan 4, 2022
Closed
@kikonen
Copy link

kikonen commented Feb 24, 2022

The thing is that "keyboard accessibility" is mandatory requirement in various places, just due to legalize rrequirements (like ADA in USA).

@Eonasdan Eonasdan mentioned this issue Apr 1, 2022
Closed
@Eonasdan
Copy link
Owner Author

Eonasdan commented Apr 1, 2022 •
edited
Loading

Hello there's a new branch: https://github.com/Eonasdan/tempus-dominus/tree/feature/accessibility that features keybindings. It's not done but some progress has been made. The keybindings only seem to work via the input field not when focus is on the widget div. If you want to take a look, feel free!

@Eonasdan Eonasdan added v6 State: planned This ticket is planned to be worked on. and removed State: Triage Tickets that need to be triaged. labels Apr 13, 2022
@Eonasdan
Copy link
Owner Author

Please check the progress of this feature here: https://stackblitz.com/edit/tempus-dominus-v6-accessibility?file=index.html

I could use some feedback on what's missing and what's working.

@kikonen
Copy link

kikonen commented Apr 22, 2022

I will try to look into it

@kikonen
Copy link

kikonen commented Apr 23, 2022 •
edited
Loading

First notice, if input group with button, is used also to open popup, it must be accessible also via that (FYI, also "button" must be implemented as button, span is fail in ADA tests). Not it seems that when popup is opened via button then keyboard access won't work. Perhaps should move focus back to input field when opening popup (?). I.e. end user most likely tries TAB, not SHIFT+TAB.

"toolbar" at top and "time select" at bottom are not TABable seemingly currently, while actionable via mouse (yep, counted as "fail" in ADA tests).

i.e. basic rule is that everything accessible via mouse must be accessible also via keyboard (and yes, been there and there can be thus cases, which don't make much sense, but when audit is done by external auditor, they just do it with "brains turned off").

@Furgas
Copy link

Furgas commented May 11, 2022

This could be useful for "how it should work":
https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/datepicker-dialog.html

@mlalpho
Copy link

mlalpho commented Jun 21, 2022

This could be useful for "how it should work": https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/datepicker-dialog.html

This page moved to https://www.w3.org/WAI/ARIA/apg/example-index/dialog-modal/datepicker-dialog.html

@Eonasdan Eonasdan mentioned this issue Oct 24, 2022
Closed
2 tasks
@Eonasdan Eonasdan moved this to 🆕 New in Tempus Dominus Oct 25, 2022
@Eonasdan Eonasdan mentioned this issue Mar 24, 2023
Closed
2 tasks
@Eonasdan Eonasdan removed the v6 label Apr 10, 2023
@Eonasdan Eonasdan added this to the 7.0 milestone Apr 10, 2023
@Eonasdan Eonasdan mentioned this issue Jul 3, 2023
Closed
Splines added a commit to MaMpf-HD/mampf that referenced this issue Jul 11, 2023
@Splines
Show datetimepicker when clicking in text field
22abf4f 
Note that the datetimepicker is not really accessible right now.
Hopefully, there will be some improvement related to this soon.
See here: Eonasdan/tempus-dominus#2390
Splines added a commit to MaMpf-HD/mampf that referenced this issue Jul 13, 2023
@Splines
Replace JQuery Datetimepicker with Tempus Dominus (#526)
22f91d7 
* Uninstall old Datetimepicker

* Remove old import hack for Datetimepicker

* Try out Tempus Dominus datetimepicker on assignments

* Show datetimepicker when clicking in text field

Note that the datetimepicker is not really accessible right now.
Hopefully, there will be some improvement related to this soon.
See here: Eonasdan/tempus-dominus#2390

* Shrink "action" and enlargen "Deadline" column

* Do not use not working jQuery version of datetimepicker

* Remove autocomplete from input field

* Improve accessibility of Datetimepicker

(keyboard events & focus)

* Add error message for invalid format & decouple from assignment view

* Clean up datetimepicker.js

* Change invalid date format string

* Fix "is-invalid" CSS classes via JS

* Get rid of old datetimepicker occurrences

* Get rid of "moment" as dependency for formatting dates

* Wait for document to be ready to init datetimepicker

Also close the datetimepicker when a date was selected

* Replace old datetimepicker in publish media modal

* Fix datetimepicker in assignments view

* Do not close datetimepicker when only time is changed

* Improve comment

* Check if date is undefined

* Prevent turbolink issue with datetimepicker

* Fix assignment title CSS id

* Empty error message upon update of assignment

* Restore old code for "assignment_title"

* Use 'before-cache' instead of 'load' with Turbolinks
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Tempus Dominus Dec 17, 2023
@chardin1
Copy link

@Eonasdan What's the status of this feature? I see you marked it as complete in December but the branch doesn't appear to have been merged and released.

@Eonasdan
Copy link
Owner Author

Eonasdan commented May 2, 2024

@chardin1 I'm no longer working on this project. I've moved on to other things. If someone wants to discuss sponsoring this issue, I'd be open to that.

@MartinRiese
Copy link

@Eonasdan We are interested in sponsoring accessibility improvements. What is the best way to contact you about the specifics? My email address is [email protected], if you want to use email.

@Eonasdan Eonasdan reopened this Dec 5, 2024
@Eonasdan
Copy link
Owner Author

Eonasdan commented Dec 5, 2024

This issue is being sponsored by Dimagi! It's now in progress.

@skublik
Copy link

skublik commented Dec 6, 2024

Hello @Eonasdan, when do you expect the function to be completed?

@Eonasdan
Copy link
Owner Author

Eonasdan commented Dec 6, 2024

@skublik soon™️. You can see the current progress in this branch. The clock bits don't work right now but the calendar should.

Per my agreement with Dimagi, they will be doing QA and a PR review before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
State: planned This ticket is planned to be worked on. State: Sponsored Type: Feature Request
Projects
Tempus Dominus
Archived in project
Milestone
7.0
Development

No branches or pull requests
7 participants
@kikonen @Furgas @Eonasdan @MartinRiese @mlalpho @skublik @chardin1