Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An empty (0b) archive log files are being created #7

Open
vash6p opened this issue Nov 19, 2021 · 3 comments
Open

An empty (0b) archive log files are being created #7

vash6p opened this issue Nov 19, 2021 · 3 comments

Comments

@vash6p
Copy link

vash6p commented Nov 19, 2021

The RollingFlatFileTraceListener is saving empty (0b) archive log files, while performing roll.
I've prepared an improvement/fix for this issue - an additional option to indicate whether to create an archive file even if it would be empty. The default value is "Always create", so the default behavior will not change.
@Chavoshi I'd be great if I could commit it and present in PR.

The funny thing is, the code regarding this functionality in the original .NET version of this library seems identical, yet empty archive files are not created, which I believe I desired for this implementation. :)

@vash6p vash6p changed the title A 0b archive log file are being created An empty (0b) archive log files are being created Nov 19, 2021
@Chavoshi
Copy link
Member

Hi @vash6p,
Any contribution is appreciated. Thanks,

@vash6p
Copy link
Author

vash6p commented Nov 23, 2021

Great,
@Chavoshi Please then grant me permission to push into repository. Currently, I'm getting

Permission to EnterpriseLibrary/logging-application-block.git denied to vash6p.

when trying to push my branch.

@Chavoshi
Copy link
Member

@vash6p ,
Please Fork the project and send a Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants