Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic watcher errors if directory is present #2731

Open
5 tasks done
wizjany opened this issue Mar 9, 2025 · 0 comments
Open
5 tasks done

Schematic watcher errors if directory is present #2731

wizjany opened this issue Mar 9, 2025 · 0 comments
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended

Comments

@wizjany
Copy link
Collaborator

wizjany commented Mar 9, 2025

WorldEdit Version

7.4.0-SNAPSHOT

Platform Version

all

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

Bug Description

The RecursiveDirectoryWatcher for schematics throws an error on startup (in its watch thread) if sub-directories are present in the schematics folder.

Issue is this line being called before the Files.isDirectory check.

Expected Behavior

Watcher picks up files in subfolders and doesn't error. Note that the initial startup is wrapped in a try/catch so the watcher actually keeps working afterwards.

Reproduction Steps

  1. mkdir {plugins,config}/WorldEdit/schematics/emptydir
  2. Start server or client.
  3. See ERROR]: com.sk89q.worldedit.util.io.file.InvalidFilenameException: Invalid characters or extension missing in log.

Can also be reproduced by adding/modifying a directory, including saving a schematic in a non-existent directory (so that WE creates it).

Anything Else?

No response

@wizjany wizjany added status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended status:accepted Will be fixed / added to WorldEdit, eventually and removed status:pending Pending acceptance or closure. labels Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended
Projects
None yet
Development

No branches or pull requests

1 participant