Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS support #72

Open
mkj-is opened this issue Feb 7, 2024 · 3 comments
Open

tvOS support #72

mkj-is opened this issue Feb 7, 2024 · 3 comments

Comments

@mkj-is
Copy link

mkj-is commented Feb 7, 2024

ETTrace does not support tvOS.

I quickly experimented with changing Package.swift and build.sh files. I built the ETTrace framework successfully, but got stuck when receiving results from the device. You can see my changes here: https://github.com/EmergeTools/ETTrace/compare/main...mkj-is:ETTrace:feature/tvos-support?expand=1

% ettrace --launch
Please open the app on the device
Re-run with `--simulator` to connect to the simulator.
Press return when ready...

Connecting to device.
Connected
Re-launch the app to start recording, then press return to exit

            
Connected
Waiting for report to be generated...

Do you see what further changes would be required to make this work?

Please note I was using Apple TV HD with USB connection.

@noahsmartin
Copy link
Member

Thanks for trying this out @mkj-is! I don't have an Apple TV to test with, but I have some ideas for what you could try. When you first ran ettrace did the tvOS app automatically quit? If it did that would indicate the peertalk channel was working because the message to restart was sent from the CLI to the app. If that worked then the next step would be to make sure the recording was stopped on the tvOS app. You could add some logs to +stopRecording in EMGPerfAnalysis.mm and make sure that gets called

@mkj-is
Copy link
Author

mkj-is commented Feb 8, 2024

Thanks for these ideas. The app quit, so the communication kind of works. Will try to debug this some more.

@noahsmartin
Copy link
Member

Added support for tvOS (and visionOS) simulators here: #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants