Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable sampling interval #20

Open
noahsmartin opened this issue Apr 27, 2023 · 0 comments
Open

Customizable sampling interval #20

noahsmartin opened this issue Apr 27, 2023 · 0 comments

Comments

@noahsmartin
Copy link
Member

The sampling interval is hardcoded to 4.5ms here:

When building the flamechart the time between traces is also capped at 5ms:

In practice this seems to work well, and lower values can cause the thread to not be scheduled in time leading to more unattributable time between traces. However, we should make it use-configurable. This might involve including the sample interval used in the data sent over PeerTalk so it can be used when constructing the flamechart. Since recording at app launch might start automatically based on the Info.plist flag I don't think the value can be an argument in the CLI, it might need to be a plist property provided to the iOS framework. Unless we add the property to the framework and an override in the CLI arguments that won't take affect if the sampling was already started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant