Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextFacsimileSplitView: TEI Facsimile not loading #370

Open
riedde opened this issue Mar 20, 2024 · 5 comments
Open

TextFacsimileSplitView: TEI Facsimile not loading #370

riedde opened this issue Mar 20, 2024 · 5 comments

Comments

@riedde
Copy link
Contributor

riedde commented Mar 20, 2024

The TEI facsimile view was fixed at #356 #339
Maybe a side-effect

@riedde riedde added this to the 1.0.0-beta.6 milestone Mar 20, 2024
@riedde
Copy link
Contributor Author

riedde commented Mar 20, 2024

@bwbohl seems that the FacsimileView is renewed now, but the similar code for the TextFacsimileSplitView needs the same. I tried it, but my skills on this are not too bad to manage.

@bwbohl bwbohl changed the title bug: TEI Facsimile SplitView is broken TextFacsimileSplitView: TEI Facsimile not loading Jun 5, 2024
@krHERO
Copy link
Member

krHERO commented Jun 5, 2024

@bwbohl and @nikobeer could you please provide some more information about this isse and what already was happening. could especially some information regarding openseadragon be helpful?

@obertsalome
Copy link

The views of text and facsimile are working separately, but the split view of both text and facsimile is not working because the facsimile is not displayed:
FacsimileOnly
TextOnly
SplitView

@riedde
Copy link
Contributor Author

riedde commented Jun 13, 2024

Side comment concerning tei-facsimileView: There is an Issue in the TaMuDi-Project to have the svg overlays also in TEI-facsimiles and not only in the (mei) sourceView. When the facsimile view is touched it can be thought about activating the overlays there. I'm willing to help.

@Diginaut
Copy link
Contributor

After comparing @bwbohl changes in FacsimileViewer.js for a similar error maybe view.setImageSet(pages); in line 66 of TextFacsimileSplitView.js has to be changed to me.pagesLoaded(pages, view);?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

5 participants