Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measureBasedView: fix image zoom levels in (IIIF) #295

Open
riedde opened this issue Dec 21, 2022 · 8 comments
Open

measureBasedView: fix image zoom levels in (IIIF) #295

riedde opened this issue Dec 21, 2022 · 8 comments
Assignees
Milestone

Comments

@riedde
Copy link
Contributor

riedde commented Dec 21, 2022

Relates to #262

When changing the zoom level in measureBasedView the image will be reloaded with the wrong dimensions. See here

Bildschirm­foto 2022-12-21 um 16 37 16

Bildschirm­foto 2022-12-21 um 16 37 21

Here also the footer is missing. This is problematic, because the dimensions are different then and the measures are moving caused by this.

Bildschirm­foto 2022-12-21 um 16 37 27

@roewenstrunk I thought we had fixed this for 1.0.0-beta.4, can you imagine, why this occurs here again? Could this problem be caused by the IIIF-providing institution?

@riedde
Copy link
Contributor Author

riedde commented Dec 22, 2022

Just for documentation:

As the images below show separate images are loaded on specific breakpoints (see URLs). One loaded the images will be displayed dependent from the zoom level but the measure zones are static (not recalculated).

Bildschirm­foto 2022-12-22 um 09 31 06

Bildschirm­foto 2022-12-22 um 09 31 10

Bildschirm­foto 2022-12-22 um 09 31 16

@riedde
Copy link
Contributor Author

riedde commented Dec 22, 2022

Resolved! This problem occurs if the encoded dimensions of the images are wrong. I worked with the Vertaktoid (4.0.0) and it encoded wrong dimensions. After correcting them and rescaling the zones, everything worked fine!

@riedde riedde closed this as completed Dec 22, 2022
@riedde
Copy link
Contributor Author

riedde commented Dec 22, 2022

Reopening, because it seems to be resolved, but there is a little adjustment of the image when zooming in and this causes a small shift of the image behind the zone. Not critical but must be resolved some day!

@riedde
Copy link
Contributor Author

riedde commented Dec 22, 2022

The problem concerning the last comment is that the footer isn't available on every zoom level. If it is missing the image height is different and then the measures are modified: In IIIF the dimensions are relative to the image, in edirom they are static coordinates.

@riedde
Copy link
Contributor Author

riedde commented Dec 22, 2022

One a special point the image fall is changing from full to snippet (see URL). The snippet has different dimensions -.-

Bildschirm­foto 2022-12-22 um 10 36 40

Bildschirm­foto 2022-12-22 um 10 36 49

@bwbohl bwbohl changed the title fix imageZoom levels in MeasureBasedView (IIIF) measureBasedView: fix image zoom levels in (IIIF) Jun 5, 2024
@bwbohl
Copy link
Member

bwbohl commented Jun 25, 2024

So if I gather correctly this is really an issue with the institution providing the images, right?

@bwbohl
Copy link
Member

bwbohl commented Jul 3, 2024

pinging @riedde

@riedde
Copy link
Contributor Author

riedde commented Jul 9, 2024

I think the solution could be that the view checks if the dimensions of the delivered image are the same than the encoded ones. If not we need a scaling function.
Can'T do that on my own at the moment.

@bwbohl bwbohl modified the milestones: 1.0.0-beta.6, 1.1.0 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

3 participants