Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Max length initialisation #8

Open
andrewshvv opened this issue Apr 28, 2021 · 2 comments
Open

Bug: Max length initialisation #8

andrewshvv opened this issue Apr 28, 2021 · 2 comments

Comments

@andrewshvv
Copy link

andrewshvv commented Apr 28, 2021 •
edited
Loading

I believe it should be sequence_length + 1 otherwise GoldenGatePartLibrary might be ignored if the whole sequence is from the library.

DnaWeaver/dnaweaver/DnaSupplier/builtin_suppliers/DnaAssemblyStation/SequenceDecomposer.py

Line 124 in 6a26b08

self.max_segment_length = sequence_length

Because here you make a comparison of this form:

DnaWeaver/dnaweaver/DnaSupplier/builtin_suppliers/DnaAssemblyStation/SequenceDecomposer.py

Line 173 in 6a26b08

ends_max = min(L + 1, start + self.max_segment_length)

@Zulko
Copy link
Member

Zulko commented Apr 28, 2021

Thanks for reporting this. Can you confirm that the fix you are suggesting is solving your issue? If yes can you open a PR?

@andrewshvv
Copy link
Author

Sorry, I thought I have answered.

Yeah, I can confirm it solved the issue, will try to make a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zulko @andrewshvv