Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: put builtin_specification to Specification folder and split it into sub folders by specification type #28

Open
Lix1993 opened this issue Dec 16, 2019 · 3 comments

Comments

@Lix1993
Copy link
Contributor

Lix1993 commented Dec 16, 2019

like this:

└── Specification
    ├── builtin_specifications
    │   ├── alignment_related
    │   │   ├── AvoidBlast.py
    │   │   └── AvoidMatches.py
    │   ├── codons_related
    │   ├── pattern_related
    │   │   ├── AvoidChanges.py
    │   │   ├── AvoidPattern.py
    │   │   └── EnforcePattern.py
    │   └── second_structure_related
    │       └── AvoudHairpins.py
    ├── SpecEvaluation
    ├── Specification.py
    └── SpecificationSet.py
@Lix1993
Copy link
Contributor Author

Lix1993 commented Dec 16, 2019

when dealing with a specific specification, I wanna read Specification.py to understand what happens.

Putting them together make me easy to find the Specification.py file.

@Zulko
Copy link
Member

Zulko commented Dec 16, 2019

I am not against it but I tried it at some point but met issues, I don't remember the details but that created a weird circular import problem in the init.py files, and created lots of nesting and the builtin_specs, which could not access SequencePattern using relative imports "." or ".." anymore.

I like the classification, but I'd wait a bit and leave this issue open until there are bit more specifications to classify.

@Lix1993
Copy link
Contributor Author

Lix1993 commented Dec 17, 2019

I think the circular import problem comes from
from .SequencePattern import SequencePattern

since the dir name SequencePattern is exactly same with file name SequencePattern.py
using relative import here change the SequencePattern in the namespace ,

rename the dir will help, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants