Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] While adding/ updating events tags are not been saved and making form unsubmissive #10197

Open
1 task done
amanpreet-dev opened this issue Jan 30, 2024 · 5 comments · May be fixed by #10221
Open
1 task done

[BUG] While adding/ updating events tags are not been saved and making form unsubmissive #10197

amanpreet-dev opened this issue Jan 30, 2024 · 5 comments · May be fixed by #10221
Assignees
@amanpreet-dev
Labels
🛠 goal: fix undefined 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@amanpreet-dev
Copy link
Contributor

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

production

Version of BioDrop (for example "v1.2.3")

2.99.10

Description

If you are creating / updating events and want to add tags, the Save button gets disabled and in case tags are removed, it remains disabled

Steps to Reproduce

  1. Go to Events Page page.
  2. Enter all the required details without adding any tags.
  3. Save button remains active
  4. Now try to add tags like javascript and enter it will be added in the below box
  5. Now the Save button gets disabled.
  6. If you remove the added tags the button remains disabled.
  • This is happening in both cases i.e. while adding an event and also while updating an event.
    both

Screenshots

Without tags
With tags

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

The issue is that the Save button is not getting its validated value reset in case tags are added or removed. This is most probably a form validation issue.
@amanpreet-dev amanpreet-dev added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Jan 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@amandamartin-dev
Copy link
Contributor

able to recreate this behavior - opening the issue

@amandamartin-dev amandamartin-dev added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Jan 30, 2024
@github-actions github-actions bot unlocked this conversation Jan 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@khainl1110
Copy link

Hi there, can I try to work on this issue? I am new to this but I know fullstack and would love to give it a try

@amanpreet-dev
Copy link
Contributor Author

Hi there, can I try to work on this issue? I am new to this but I know fullstack and would love to give it a try

Hi @khainl1110, I have already started the work and In case I am not able to do it in the next few days, I will update you and then you can try on this issue.

@eddiejaoude eddiejaoude added the 🔢 points: 3 undefined label Feb 4, 2024
@amanpreet-dev amanpreet-dev changed the title [BUG] While adding/ updating evets tags are not been saved and making form unsubmissive [BUG] While adding/ updating events tags are not been saved and making form unsubmissive Feb 5, 2024
@amanpreet-dev amanpreet-dev linked a pull request Feb 5, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanpreet-dev amanpreet-dev

Labels
🛠 goal: fix undefined 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Milestone
No milestone
4 participants
@eddiejaoude @khainl1110 @amanpreet-dev @amandamartin-dev