Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect rounding in scaled_rounding with scale of 1 #1042

Open
dhebbeker opened this issue Mar 2, 2025 · 0 comments
Open

incorrect rounding in scaled_rounding with scale of 1 #1042

dhebbeker opened this issue Mar 2, 2025 · 0 comments
Labels

Comments

@dhebbeker
Copy link
Contributor

Most rounding functions in scaled_rounding don't work as intended if SCALING==1. I suggest to

  • either forbid to use a scaling of 1:
    • note in the documentation
    • static_assert in the code
  • or use template meta-programming to return value if SCALING==1

Can you please clarify which behaviour is intended? Then somebody could start a pull request...

Based on ETL version 20.40.0.

@dhebbeker dhebbeker changed the title incorrect rounding of in scaled_rounding with scale of 1 incorrect rounding in scaled_rounding with scale of 1 Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants