incorrect rounding of scaled natural numbers in scaled_rounding

[dhebbeker]

Some of the scaled rounding functions incorrectly round scaled natural numbers. For example scaled 5.0 is rounded to 6.0 with round_infinity_scaled(). According to the referenced paper in the documentation for round-ceiling (toward positive infinity) this should result to 5.0:

In the source code I see that before division with the scale, SCALING is added (or subtracted) to (or from) the rational parameter value in most rounding functions. Instead the term should be (SCALING - 1). A fix would depend on the intended functionality:

• either adjust the documentation
• change the rounding in the source code

Can you please clarify which behaviour is intended? Then somebody could start a pull request...

_{Based on ETL version 20.40.0.}

[jwellbelove]

The functionality should follow the referenced paper.