Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadBanner function Freeze the App in 2.0.5 #56

Open
wuxiaomo6174 opened this issue Jan 16, 2025 · 8 comments
Open

loadBanner function Freeze the App in 2.0.5 #56

wuxiaomo6174 opened this issue Jan 16, 2025 · 8 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@wuxiaomo6174
Copy link

I use the example code of V2.0.5 in xcode 16. After lauch the app, it will freeze the app like following png. The error log is in the right.
Dive into the code, the loadBanner() is the cause. If I remove this function, everything is OK.
Image

@EMI-INDO
Copy link
Owner

I said it like before explain in more detail?

is this a capacitor platform or cordova or Quasar?

cordova version?
capacitor version?
Quasar version?

each framework will handle plugins differently,
so when you use capacitor and I test it with cordova the results will be different.

so clarity is a must so that I can more easily handle any problems.

@EMI-INDO EMI-INDO self-assigned this Jan 16, 2025
@EMI-INDO EMI-INDO added the help wanted Extra attention is needed label Jan 16, 2025
@wuxiaomo6174
Copy link
Author

Sorry for it. I didn't realize capacitor is different with cordova.
My test env is capacitor 6.0.
Other detailed needed?

@EMI-INDO
Copy link
Owner

yes I just tested it on the capacitor, as you said the screen froze I also got it.

I'm sorry I have some work to do this week or two, so it looks like this repair will be continued next month.

Even though I don't make IOS apps for the app store, this is still my responsibility, gradually everything will be updated and fixed.

@merbin2012
Copy link
Contributor

@wuxiaomo6174
Hi, this plugin works well in Capacitor too, I'm using capacitor. But I'm not yet tested with the latest version, I think last I was worked with 2.0.0, within few days I'll again move to iOs in that time I'll help you..

Did you properly configured the appid?
Did you install the pod?

@wuxiaomo6174
Copy link
Author

@merbin2012
1.8.9- 2.0.5 most function work well. The banner froze exists in version 2.0.5. You can skip loadBanner to avoid it.

@EMI-INDO
Copy link
Owner

I still have confusion, in some cases whether the banner should push the webview or reduce the webview height.

there are still many adjustments such as
When safeAreaInsets is hidden, the banner must shift to safeAreaInsets, then the webview height must be reset, and vice versa.

This only starts when the banner position is at the bottom, not to mention the logic when the banner is at the top.

although actually all of this can be manipulated with html elements but not everyone can do it, so the tactical way all of this must be handled by the plugin.

Everything must go through a gradual process.

@wuxiaomo6174
Copy link
Author

Hi @EMI-INDO
In my opinion,
When the banner is at the top, then shrik webview and then make it under the banner. Other admob plugin has this behavior.
It will has two parts: banner and the shriked webview.
When is top , then show: the banner + shriked webview.
When bottom, then show: shriked webview+ banner.

Hope it helps.

@EMI-INDO EMI-INDO added the bug Something isn't working label Jan 26, 2025
@EMI-INDO
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants