Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review - BEFORE/AFTER preprocess #107

Open
shaunharrigan opened this issue Aug 13, 2019 · 1 comment
Open

Review - BEFORE/AFTER preprocess #107

shaunharrigan opened this issue Aug 13, 2019 · 1 comment
Labels

Comments

@shaunharrigan
Copy link

shaunharrigan commented Aug 13, 2019

Hi @tommylees112 and @gabrieltseng,

The plot generated using 'before.VHI.plot()' looks obviously incorrect. If you run the AFTER preprocess, does this then fix the peculiar x/y axes (HEIGHT/WIDTH)? If so perhaps it would be worth showing the corrected map too? Or perhaps I've misunderstood the BEFORE/AFTER preprocess?!

PS I can't add the "review" label as I'm not a contributor.

@tommylees112
Copy link
Contributor

tommylees112 commented Aug 13, 2019

Hi Shaun! Thanks for your review question.

Yes the VHIPreprocessor fixes all of the peculiarities from the VHI dataset. It was one of the more involved preprocessors and required a) changing HEIGHT/WIDTH dimensions into lat and lon, assigning a time dimension from the filename and then regridding/selecting the region of interest as with other Preprocessors.

I think that's what you were referring to? Let me know if I misunderstood!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants